gvc: remove unused 'gvevent_modify'

The `modify` field was added to `gvdevice_callbacks_t` in
50df9e82edcb61c5650f81ca317a31c9493ed07e, but seemingly has never been used by
any in-tree plugin. This commit removes a no-op, never-called callback for it,
squashing some -Wunused-parameter warnings.

This commit does not remove the member because it is part of the public API. We
are assuming the convention is to check these pointers against null before
calling them, like the other GVC structs. But the struct has no comment
explaining it nor how it is meant to be used, so we cannot be sure how/if users
would be relying on this.

diff --git a/lib/gvc/gvevent.c b/lib/gvc/gvevent.c
index 333abd9d2ce675295f0d0448d4464004b20cbba0..8cbaf4ec5bf877fdacd6e8f5add2d3d0fa15484a 100644 (file)
--- a/lib/gvc/gvevent.c
+++ b/lib/gvc/gvevent.c
@@ -545,11 +545,6 @@ static int toggle_fit_cb(GVJ_t * job)
     return 0;
 }
 
-static void gvevent_modify (GVJ_t * job, const char *name, const char *value)
-{
-    /* FIXME */
-}
-
 static void gvevent_delete (GVJ_t * job)
 {
     /* FIXME */
@@ -653,7 +648,7 @@ gvdevice_callbacks_t gvdevice_callbacks = {
     gvevent_button_press,
     gvevent_button_release,
     gvevent_motion,
-    gvevent_modify,
+    NULL, // modify
     gvevent_delete,
     gvevent_read,
     gvevent_layout,