proto was dereffed above and is known to be good. No need for X.

Reported by Klocwork, #39.

diff --git a/Modules/_ctypes/cfield.c b/Modules/_ctypes/cfield.c
index b147ae2ed94e20403e3f53026a8d007be31d7099..3595b052a9931243b4670913435542d28769d29c 100644 (file)
--- a/Modules/_ctypes/cfield.c
+++ b/Modules/_ctypes/cfield.c
@@ -124,7 +124,7 @@ CField_FromDesc(PyObject *desc, int index,
        self->getfunc = getfunc;
        self->index = index;
 
-       Py_XINCREF(proto);
+       Py_INCREF(proto);
        self->proto = proto;
 
        switch (fieldtype) {