- Christian Schmitz noticed that the progress meter/callback was not properly

  used during the FTP connection phase (after the actual TCP connect), while
  it of course should be. I also made the speed check get called correctly so
  that really slow servers will trigger that properly too.

diff --git a/CHANGES b/CHANGES
index 2d7b7ba62fbcd5febe9049fc4e467df5e3034b0b..3bd88093101b6e07ec73959e2186f499d453c16b 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,12 @@
 
                                   Changelog
 
+Daniel Stenberg (11 Nov 2009)
+- Christian Schmitz noticed that the progress meter/callback was not properly
+  used during the FTP connection phase (after the actual TCP connect), while
+  it of course should be. I also made the speed check get called correctly so
+  that really slow servers will trigger that properly too.
+
 Kamil Dudka (5 Nov 2009)
 - Dropped misleading timeouts in libcurl-NSS and made sure the SSL socket works
   in non-blocking mode.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index fc8c3dd3636949b831d1ca0e1d9becdc12fa8c3d..08d7215d81d559caca59c43d39535ff744d05720 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -15,6 +15,7 @@ This release includes the following bugfixes:
 
  o progress meter percentage and transfer time estimates fixes
  o portability enhancement for OS's without orthogonal directory tree structure
+ o progress meter/callback during FTP connection
 
 This release includes the following known bugs:
 
@@ -23,6 +24,6 @@ This release includes the following known bugs:
 This release would not have looked like this without help, code, reports and
 advice from friends like these:
 
- 
+ Yang Tse, Kamil Dudka, Christian Schmitz
 
         Thanks! (and sorry if I forgot to mention someone)

diff --git a/lib/ftp.c b/lib/ftp.c
index a2332234d205733da134610608a591db00487530..14d4b929ff3c3dc4e7bb637f70dfe13b3c88f71d 100644 (file)
--- a/lib/ftp.c
+++ b/lib/ftp.c
@@ -90,6 +90,7 @@
 #include "multiif.h"
 #include "url.h"
 #include "rawstr.h"
+#include "speedcheck.h"
 
 #define _MPRINTF_REPLACE /* use our functions only */
 #include <curl/mprintf.h>
@@ -3069,6 +3070,13 @@ static CURLcode ftp_easy_statemach(struct connectdata *conn)
       result = ftp_statemach_act(conn);
       if(result)
         break;
+      else if(Curl_pgrsUpdate(conn))
+        result = CURLE_ABORTED_BY_CALLBACK;
+      else
+        result = Curl_speedcheck(data, Curl_tvnow());
+
+      if(result)
+        break;
     }
   }