- pythunrun.c, Py_Finalize(): move the call to _Py_PrintReferences()

  even farther down, to just before the call to
  _PyObject_DebugMallocStats().  This required the following changes:

- pystate.c, PyThreadState_GetDict(): changed not to raise an
  exception or issue a fatal error when no current thread state is
  available, but simply return NULL without raising an exception
  (ever).

- object.c, Py_ReprEnter(): when PyThreadState_GetDict() returns NULL,
  don't raise an exception but return 0.  This means that when
  printing a container that's recursive, printing will go on and on
  and on.  But that shouldn't happen in the case we care about (see
  first bullet).

- Updated Misc/NEWS and Doc/api/init.tex to reflect changes to
  PyThreadState_GetDict() definition.

diff --git a/Doc/api/init.tex b/Doc/api/init.tex
index f0ca287e0452c9aa05234dce006ee553b34bb2c2..388f479457b846d7a07edadd8d1ef5da7e501d34 100644 (file)
--- a/Doc/api/init.tex
+++ b/Doc/api/init.tex
@@ -677,9 +677,12 @@ interpreter lock has been created.
 \begin{cfuncdesc}{PyObject*}{PyThreadState_GetDict}{}
   Return a dictionary in which extensions can store thread-specific
   state information.  Each extension should use a unique key to use to
-  store state in the dictionary.  If this function returns \NULL, an
-  exception has been raised and the caller should allow it to
-  propagate.
+  store state in the dictionary.  It is okay to call this function
+  when no current thread state is available.
+  If this function returns \NULL, no exception has been raised and the
+  caller should assume no current thread state is available.
+  \versionchanged[Previously this could only be called when a current
+  thread is active, and \NULL meant that an exception was raised]{2.3}
 \end{cfuncdesc}
 
 

diff --git a/Misc/NEWS b/Misc/NEWS
index 4f24edcb3d68d90b903004d25c85954a39e334e7..70bc17cafeb205e7f630b5ae33c0f76a3bb7bbc5 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -150,6 +150,10 @@ Build
 C API
 -----
 
+- PyThreadState_GetDict() was changed not to raise an exception or
+  issue a fatal error when no current thread state is available.  This
+  makes it possible to print dictionaries when no thread is active.
+
 - LONG_LONG was renamed to PY_LONG_LONG.
 
 - Added PyObject_SelfIter() to fill the tp_iter slot for the

diff --git a/Objects/object.c b/Objects/object.c
index 1a1d1d2a847b3dfc75c83fbfae53c49235d7ca37..c8762193094b82241d072954d977709b60b4a2bb 100644 (file)
--- a/Objects/object.c
+++ b/Objects/object.c
@@ -2119,7 +2119,7 @@ Py_ReprEnter(PyObject *obj)
 
        dict = PyThreadState_GetDict();
        if (dict == NULL)
-               return -1;
+               return 0;
        list = PyDict_GetItemString(dict, KEY);
        if (list == NULL) {
                list = PyList_New(0);

diff --git a/Python/pystate.c b/Python/pystate.c
index 1139851c3c1e445e9a8f99e5a3d44b4f7d1766bb..62bf09b6261237ecd639f130908a5f151c8e036a 100644 (file)
--- a/Python/pystate.c
+++ b/Python/pystate.c
@@ -266,17 +266,21 @@ PyThreadState_Swap(PyThreadState *new)
 /* An extension mechanism to store arbitrary additional per-thread state.
    PyThreadState_GetDict() returns a dictionary that can be used to hold such
    state; the caller should pick a unique key and store its state there.  If
-   PyThreadState_GetDict() returns NULL, an exception has been raised (most
-   likely MemoryError) and the caller should pass on the exception. */
+   PyThreadState_GetDict() returns NULL, an exception has *not* been raised
+   and the caller should assume no per-thread state is available. */
 
 PyObject *
 PyThreadState_GetDict(void)
 {
        if (_PyThreadState_Current == NULL)
-               Py_FatalError("PyThreadState_GetDict: no current thread");
+               return NULL;
 
-       if (_PyThreadState_Current->dict == NULL)
-               _PyThreadState_Current->dict = PyDict_New();
+       if (_PyThreadState_Current->dict == NULL) {
+               PyObject *d;
+               _PyThreadState_Current->dict = d = PyDict_New();
+               if (d == NULL)
+                       PyErr_Clear();
+       }
        return _PyThreadState_Current->dict;
 }
 

diff --git a/Python/pythonrun.c b/Python/pythonrun.c
index fdbd19f187666eb0739fb39a520b9a2603139f31..fbf4283ea9fd577a1815d5c6397860cc5d3ee420 100644 (file)
--- a/Python/pythonrun.c
+++ b/Python/pythonrun.c
@@ -280,14 +280,6 @@ Py_Finalize(void)
        /* Clear interpreter state */
        PyInterpreterState_Clear(interp);
 
-#ifdef Py_TRACE_REFS
-       /* Dump references -- this may implicitly need the thread state,
-          so this is the last possible place where we can do this. */
-       if (Py_GETENV("PYTHONDUMPREFS")) {
-               _Py_PrintReferences(stderr);
-       }
-#endif /* Py_TRACE_REFS */
-
        /* Delete current thread */
        PyThreadState_Swap(NULL);
        PyInterpreterState_Delete(interp);
@@ -314,6 +306,14 @@ Py_Finalize(void)
 
        PyGrammar_RemoveAccelerators(&_PyParser_Grammar);
 
+#ifdef Py_TRACE_REFS
+       /* Dump references -- this may implicitly need the thread state,
+          so this is the last possible place where we can do this. */
+       if (Py_GETENV("PYTHONDUMPREFS")) {
+               _Py_PrintReferences(stderr);
+       }
+#endif /* Py_TRACE_REFS */
+
 #ifdef PYMALLOC_DEBUG
        if (Py_GETENV("PYTHONMALLOCSTATS"))
                _PyObject_DebugMallocStats();