Issue #16431: Finally, consider all permutations.

diff --git a/Lib/test/test_decimal.py b/Lib/test/test_decimal.py
index ea18c6393e80531a0bd828c1ed6fdb7b5920b093..dd4c73cdf14bbb4da44f7578be7b99abd97fea96 100644 (file)
--- a/Lib/test/test_decimal.py
+++ b/Lib/test/test_decimal.py
@@ -2029,7 +2029,7 @@ class UsabilityTest(unittest.TestCase):
         Decimal = self.decimal.Decimal
 
         class MyDecimal(Decimal):
-            pass
+            y = None
 
         d1 = MyDecimal(1)
         d2 = MyDecimal(2)
@@ -2047,14 +2047,29 @@ class UsabilityTest(unittest.TestCase):
         self.assertIs(type(d), MyDecimal)
         self.assertEqual(d, d1)
 
-        a = Decimal('1.0')
-        b = MyDecimal(a)
-        self.assertIs(type(b), MyDecimal)
-        self.assertEqual(a, b)
-
-        c = Decimal(b)
-        self.assertIs(type(c), Decimal)
-        self.assertEqual(a, c)
+        # Decimal(Decimal)
+        d = Decimal('1.0')
+        x = Decimal(d)
+        self.assertIs(type(x), Decimal)
+        self.assertEqual(x, d)
+
+        # MyDecimal(Decimal)
+        m = MyDecimal(d)
+        self.assertIs(type(m), MyDecimal)
+        self.assertEqual(m, d)
+        self.assertIs(m.y, None)
+
+        # Decimal(MyDecimal)
+        x = Decimal(m)
+        self.assertIs(type(x), Decimal)
+        self.assertEqual(x, d)
+
+        # MyDecimal(MyDecimal)
+        m.y = 9
+        x = MyDecimal(m)
+        self.assertIs(type(x), MyDecimal)
+        self.assertEqual(x, d)
+        self.assertIs(x.y, None)
 
     def test_implicit_context(self):
         Decimal = self.decimal.Decimal

diff --git a/Modules/_decimal/_decimal.c b/Modules/_decimal/_decimal.c
index 0e1d3044cad18ea3c556cb09734ea47029c0d18f..e951ded5fff011f78277555eea2c536506e2fc9d 100644 (file)
--- a/Modules/_decimal/_decimal.c
+++ b/Modules/_decimal/_decimal.c
@@ -2338,14 +2338,14 @@ PyDecType_FromFloat(PyTypeObject *type, PyObject *v,
     return dec;
 }
 
-/* Return a new PyDecObject (subtype) from a Decimal. */
+/* Return a new PyDecObject or a subtype from a Decimal. */
 static PyObject *
 PyDecType_FromDecimalExact(PyTypeObject *type, PyObject *v, PyObject *context)
 {
     PyObject *dec;
     uint32_t status = 0;
 
-    if (type == Py_TYPE(v)) {
+    if (type == &PyDec_Type && PyDec_CheckExact(v)) {
         Py_INCREF(v);
         return v;
     }