]> granicus.if.org Git - python/commitdiff
I followed MA Lemberg's suggestion and added comments to the late initialization...
authorChristian Heimes <christian@cheimes.de>
Mon, 3 Dec 2007 14:28:04 +0000 (14:28 +0000)
committerChristian Heimes <christian@cheimes.de>
Mon, 3 Dec 2007 14:28:04 +0000 (14:28 +0000)
Modules/xxmodule.c

index 9fb4483b6f29ed8e88576e22a514ce82178b5534..8807298289f6d834a81bffc41d5e84034fc06cec 100644 (file)
@@ -246,7 +246,7 @@ static PyTypeObject Str_Type = {
        0,                      /*tp_methods*/
        0,                      /*tp_members*/
        0,                      /*tp_getset*/
-       0,                      /*tp_base*/
+       0, /* see initxx */     /*tp_base*/
        0,                      /*tp_dict*/
        0,                      /*tp_descr_get*/
        0,                      /*tp_descr_set*/
@@ -301,14 +301,14 @@ static PyTypeObject Null_Type = {
        0,                      /*tp_methods*/
        0,                      /*tp_members*/
        0,                      /*tp_getset*/
-       0,                      /*tp_base*/
+       0, /* see initxx */     /*tp_base*/
        0,                      /*tp_dict*/
        0,                      /*tp_descr_get*/
        0,                      /*tp_descr_set*/
        0,                      /*tp_dictoffset*/
        0,                      /*tp_init*/
        0,                      /*tp_alloc*/
-       0,                      /*tp_new*/
+       0, /* see initxx */     /*tp_new*/
        0,                      /*tp_free*/
        0,                      /*tp_is_gc*/
 };
@@ -341,13 +341,15 @@ initxx(void)
 {
        PyObject *m;
 
+       /* Due to cross platform compiler issues the slots must be filled
+        * here. It's required for portability to Windows without requiring
+        * C++. */
        Null_Type.tp_base = &PyBaseObject_Type;
        Null_Type.tp_new = PyType_GenericNew;
        Str_Type.tp_base = &PyUnicode_Type;
 
        /* Finalize the type object including setting type of the new type
-        * object; doing it here is required for portability to Windows 
-        * without requiring C++. */
+        * object; doing it here is required for portability, too. /*
        if (PyType_Ready(&Xxo_Type) < 0)
                return;