Driver: Tweak -Xarch diags a bit more, we can't actually differentiate between

unknown and "required more arguments", but only the latter should be feasible in
practice.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@129919 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/clang/Basic/DiagnosticDriverKinds.td b/include/clang/Basic/DiagnosticDriverKinds.td
index 6397e774f4a7e549c74d85557c38640502b63729..edc289f93fdd2aa6117a71fcee26561aab6947b2 100644 (file)
--- a/include/clang/Basic/DiagnosticDriverKinds.td
+++ b/include/clang/Basic/DiagnosticDriverKinds.td
@@ -39,8 +39,6 @@ def err_drv_invalid_darwin_version : Error<
   "invalid Darwin version number: %0">;
 def err_drv_missing_argument : Error<
   "argument to '%0' is missing (expected %1 %plural{1:value|:values}1)">;
-def err_drv_invalid_Xarch_argument_unknown : Error<
-  "invalid Xarch argument: '%0', option is unrecognized">;
 def err_drv_invalid_Xarch_argument_with_args : Error<
   "invalid Xarch argument: '%0', options requiring arguments are unsupported">;
 def err_drv_invalid_Xarch_argument_isdriver : Error<

diff --git a/lib/Driver/ToolChains.cpp b/lib/Driver/ToolChains.cpp
index 75cb9353aa00aff933ad250d00c2f4b1fec6cb5b..c5d34daf2f3206bcb97e01ba34b5aab57d03c3bc 100644 (file)
--- a/lib/Driver/ToolChains.cpp
+++ b/lib/Driver/ToolChains.cpp
@@ -555,11 +555,7 @@ DerivedArgList *Darwin::TranslateArgs(const DerivedArgList &Args,
       // driver behavior; that isn't going to work in our model. We
       // use isDriverOption() as an approximation, although things
       // like -O4 are going to slip through.
-      if (!XarchArg) {
-        getDriver().Diag(clang::diag::err_drv_invalid_Xarch_argument_unknown)
-          << A->getAsString(Args);
-        continue;
-      } else if (Index > Prev + 1) {
+      if (!XarchArg || Index > Prev + 1) {
         getDriver().Diag(clang::diag::err_drv_invalid_Xarch_argument_with_args)
           << A->getAsString(Args);
         continue;