]> granicus.if.org Git - php/commitdiff
Fixed res leak
authorXinchen Hui <laruence@php.net>
Wed, 15 Apr 2015 02:38:55 +0000 (10:38 +0800)
committerStanislav Malyshev <stas@php.net>
Wed, 15 Apr 2015 04:15:50 +0000 (21:15 -0700)
Zend/zend_exceptions.c

index 1ca2eadbf4ccd765c7d6431ab22df93b3d20d77d..06be9885d5aafdfc0eb0e15d9ed14553e27ed27d 100644 (file)
@@ -587,13 +587,14 @@ ZEND_METHOD(exception, getTraceAsString)
 
        DEFAULT_0_PARAMS;
        
-       res = estrdup("");
-       str = &res;
-
        trace = zend_read_property(default_exception_ce, getThis(), "trace", sizeof("trace")-1, 1 TSRMLS_CC);
        if(Z_TYPE_P(trace) != IS_ARRAY) {
                RETURN_FALSE;
        }
+
+       res = estrdup("");
+       str = &res;
+
        zend_hash_apply_with_arguments(Z_ARRVAL_P(trace) TSRMLS_CC, (apply_func_args_t)_build_trace_string, 3, str, len, &num);
 
        s_tmp = emalloc(1 + MAX_LENGTH_OF_LONG + 7 + 1);