Fix an obnoxious typo in the bufferevent_timeout_filter test

We were using the same bufferevent as the child of two filtering parents,
orphaning another.  This made one get freed twice, and the other not at all.

Possible fix for bug 2963306 spotted by Doug Cuthbertson.

diff --git a/test/regress_bufferevent.c b/test/regress_bufferevent.c
index 7d7014e281d0490293249772e47318bae8264b2f..1960077bc777bd7dffe658b02c62109f10a68957 100644 (file)
--- a/test/regress_bufferevent.c
+++ b/test/regress_bufferevent.c
@@ -682,7 +682,7 @@ test_bufferevent_timeouts(void *arg)
                struct bufferevent *bevf1, *bevf2;
                bevf1 = bufferevent_filter_new(bev1, NULL, NULL,
                    BEV_OPT_CLOSE_ON_FREE, NULL, NULL);
-               bevf2 = bufferevent_filter_new(bev1, NULL, NULL,
+               bevf2 = bufferevent_filter_new(bev2, NULL, NULL,
                    BEV_OPT_CLOSE_ON_FREE, NULL, NULL);
                tt_assert(bevf1);
                tt_assert(bevf2);