]> granicus.if.org Git - python/commitdiff
expected failure should not trigger failfast behavior in unittest.
authorMichael Foord <fuzzyman@voidspace.org.uk>
Mon, 22 Mar 2010 01:56:54 +0000 (01:56 +0000)
committerMichael Foord <fuzzyman@voidspace.org.uk>
Mon, 22 Mar 2010 01:56:54 +0000 (01:56 +0000)
Lib/test/test_unittest.py
Lib/unittest/main.py
Lib/unittest/result.py

index 05c0182bfaf8ff217e98033b77ab31117d3ccb4a..5d51ffc547ce26e57c2d9f4ef7ac38b76476bbb7 100644 (file)
@@ -2113,12 +2113,6 @@ class Test_TestResult(TestCase):
         result.addUnexpectedSuccess(None)
         self.assertTrue(result.shouldStop)
 
-        result = unittest.TestResult()
-        result._exc_info_to_string = lambda *_: ''
-        result.failfast = True
-        result.addExpectedFailure(None, None)
-        self.assertTrue(result.shouldStop)
-
     def testFailFastSetByRunner(self):
         runner = unittest.TextTestRunner(stream=StringIO(), failfast=True)
         def test(result):
index 8fd23c0691e8afb454462f9fd1267f3359237a4d..35466ccfabc27fc6b7a791deeda495761e0c4e26 100644 (file)
@@ -178,7 +178,7 @@ class TestProgram(object):
                 testRunner = self.testRunner(verbosity=self.verbosity,
                                              failfast=self.failfast)
             except TypeError:
-                # didn't accept the verbosity or failfast argument
+                # didn't accept the verbosity or failfast arguments
                 testRunner = self.testRunner()
         else:
             # it is assumed to be a TestRunner instance
index 96d56a114e966c60890525f5921afefa4cbad5ae..ec80e8eea5871c4a6c9aa856f902ecfbba2a20db 100644 (file)
@@ -81,7 +81,6 @@ class TestResult(object):
         """Called when a test is skipped."""
         self.skipped.append((test, reason))
 
-    @failfast
     def addExpectedFailure(self, test, err):
         """Called when an expected failure/error occured."""
         self.expectedFailures.append(