Issue #7082: When falling back to the MIME 'name' parameter, the

correct place to look for it is the Content-Type header.

Patch by Darren Worrall.

diff --git a/Lib/email/message.py b/Lib/email/message.py
index 129f4ba405c61fc7aac33b5cedd9fb15afe5b791..db09deefe26b5e619f056436c8a8086ac4a8c6d2 100644 (file)
--- a/Lib/email/message.py
+++ b/Lib/email/message.py
@@ -674,7 +674,7 @@ class Message:
         missing = object()
         filename = self.get_param('filename', missing, 'content-disposition')
         if filename is missing:
-            filename = self.get_param('name', missing, 'content-disposition')
+            filename = self.get_param('name', missing, 'content-type')
         if filename is missing:
             return failobj
         return utils.collapse_rfc2231_value(filename).strip()

diff --git a/Lib/email/test/data/msg_44.txt b/Lib/email/test/data/msg_44.txt
index ae462a61be65ab822eb419b12551138edd1dcbc6..15a225287bd8f7a107082b69e2e5817ce6ff1f64 100644 (file)
--- a/Lib/email/test/data/msg_44.txt
+++ b/Lib/email/test/data/msg_44.txt
@@ -16,16 +16,14 @@ X-Oblique-Strategy: Make a door into a window
 
 
 --h90VIIIKmx
-Content-Type: text/plain
-Content-Disposition: inline; name="msg.txt"
+Content-Type: text/plain; name="msg.txt"
 Content-Transfer-Encoding: 7bit
 
 a simple kind of mirror
 to reflect upon our own
 
 --h90VIIIKmx
-Content-Type: text/plain
-Content-Disposition: inline; name="msg.txt"
+Content-Type: text/plain; name="msg.txt"
 Content-Transfer-Encoding: 7bit
 
 a simple kind of mirror

diff --git a/Misc/ACKS b/Misc/ACKS
index 753ca7bdbc43cc98b5eca1ac8863c7082efd7c10..6383a46a3abe75208191bdda63b178a154312ce4 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -807,6 +807,7 @@ David Wolever
 Klaus-Juergen Wolf
 Dan Wolfe
 Richard Wolff
+Darren Worrall
 Gordon Worley
 Thomas Wouters
 Heiko Wundram

diff --git a/Misc/NEWS b/Misc/NEWS
index f1fad86057b42a37894e87a67ea6f4685d406ef6..f3941c095576839171d870b5dc9bbba8f0c2426d 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -398,6 +398,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #7082: When falling back to the MIME 'name' parameter, the
+  correct place to look for it is the Content-Type header.
+
 - Issue #7048: Force Decimal.logb to round its result when that result
   is too large to fit in the current precision.