Two issues pointed out by Gary Peck:

*) Note that adding and removing frames from the ID3v2::Tag will invalidate
   iterators on the frame list
*) Correct the number of genres -- it should be 148 instead of 147.  You
   can all have your Synthpop genre back now.  :-)

CCMAIL:Gary Peck <gbpeck@sbcglobal.net>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@318067 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

diff --git a/mpeg/id3v1/id3v1genres.cpp b/mpeg/id3v1/id3v1genres.cpp
index e1e0ca2153b0c871d9fd87b4f17cdb06a6776886..af20dc000fe466a5f92eecb17bc4ad51123c7681 100644 (file)
--- a/mpeg/id3v1/id3v1genres.cpp
+++ b/mpeg/id3v1/id3v1genres.cpp
@@ -26,7 +26,7 @@ using namespace TagLib;
 namespace TagLib {
   namespace ID3v1 {
 
-    static const int genresSize = 147;
+    static const int genresSize = 148;
     static const String genres[] = {
       "Blues",
       "Classic Rock",

diff --git a/mpeg/id3v2/id3v2tag.h b/mpeg/id3v2/id3v2tag.h
index bcc24130df7f41d0a22470236c363a65bf5df0b8..7308e11738e1e751c4236483d579f1bbfc5332c7 100644 (file)
--- a/mpeg/id3v2/id3v2tag.h
+++ b/mpeg/id3v2/id3v2tag.h
@@ -232,17 +232,26 @@ namespace TagLib {
       /*!
        * Add a frame to the tag.  At this point the tag takes ownership of
        * the frame and will handle freeing its memory.
+       *
+       * \note Using this method will invalidate any pointers on the list
+       * returned by frameList()
        */
       void addFrame(Frame *frame);
 
       /*!
        * Remove a frame from the tag.  If \a del is true the frame's memory
        * will be freed; if it is false, it must be deleted by the user.
+       *
+       * \note Using this method will invalidate any pointers on the list
+       * returned by frameList()
        */
       void removeFrame(Frame *frame, bool del = true);
 
       /*!
        * Remove all frames of type \a id from the tag and free their memory.
+       *
+       * \note Using this method will invalidate any pointers on the list
+       * returned by frameList()
        */
       void removeFrames(const ByteVector &id);