* lib/get_gid.c: gidstr should not be NULL, but the check was

	meant to make sure it is not empty.
	* lib/get_uid.c: Likewise.

diff --git a/ChangeLog b/ChangeLog
index 7b160ec0b61fc29fc36cfdfeee601338cdfe1a20..24334a5c512fa24c6b884d8e04b5568f277ec59b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2009-04-22  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * lib/get_gid.c: gidstr should not be NULL, but the check was
+       meant to make sure it is not empty.
+       * lib/get_uid.c: Likewise.
+
+2009-04-22  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * lib/getdef.c: Added splint annotations.
+       * lib/getdef.c: Ignore fputs() return value.
+       * lib/getdef.c: Use EXIT_FAILURE / EXIT_SUCCESS for exit()
+
 2009-04-22  Nicolas François  <nicolas.francois@centraliens.net>
 
        * src/faillog.c: Added splint annotations.

diff --git a/lib/get_gid.c b/lib/get_gid.c
index c896258813e948e29faf9d0ec56127bd9b516fd1..d13b95ad1f1f737b0bbc132e8b13596eb451957c 100644 (file)
--- a/lib/get_gid.c
+++ b/lib/get_gid.c
@@ -41,7 +41,7 @@ int get_gid (const char *gidstr, gid_t *gid)
 
        errno = 0;
        val = strtoll (gidstr, &endptr, 10);
-       if (   ('\0' == gidstr)
+       if (   ('\0' == *gidstr)
            || ('\0' != *endptr)
            || (ERANGE == errno)
            || (val != (gid_t)val)) {

diff --git a/lib/get_uid.c b/lib/get_uid.c
index 92a09caec8a9b2d167d2a2c19fb01bdc6c9e803a..dd90bad34b1df6ed89111ac60b04e9f01df07ac0 100644 (file)
--- a/lib/get_uid.c
+++ b/lib/get_uid.c
@@ -41,7 +41,7 @@ int get_uid (const char *uidstr, uid_t *uid)
 
        errno = 0;
        val = strtoll (uidstr, &endptr, 10);
-       if (   ('\0' == uidstr)
+       if (   ('\0' == *uidstr)
            || ('\0' != *endptr)
            || (ERANGE == errno)
            || (val != (uid_t)val)) {