Relevant BUGIDs: 460717

Purpose of commit: bugfix

Commit summary:
---------------
it seems there was a slight problem with md5 compatibility with
respect to bigendian non-md5 hash support.

diff --git a/CHANGELOG b/CHANGELOG
index d84253e56ccfda6465c928e6a923fa562fb53976..413c56c1156132fdd9d813cf383b14264e3250a1 100644 (file)
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -49,6 +49,9 @@ bug report - outstanding bugs are listed here:
 0.76: please submit patches for this section with actual code/doc
       patches!
 
+* pam_pwdb: Solar Designer pointed out that there was a problem with
+  the compatibility support for md5 password hashing. (Bug 460717 -
+  agmorgan)
 * pam_issue: Nalin found segfaulting problems if the PAM_USER_PROMPT
   is unset, found some similar problems with assumptions about
   realloc. (Bug 476983 - agmorgan)

diff --git a/modules/pam_pwdb/pam_unix_md.-c b/modules/pam_pwdb/pam_unix_md.-c
index d9b2c51b205a2a7cc0cdc87315c92eca7797e347..654767321dfcad6603168a2bb2b10b0d7d5e9e12 100644 (file)
--- a/modules/pam_pwdb/pam_unix_md.-c
+++ b/modules/pam_pwdb/pam_unix_md.-c
@@ -65,7 +65,7 @@ static char *_pam_md_compat(const char *key, const char *salt)
         x = x_strdup(e);                    /* put e in malloc()ed memory */
         _pam_overwrite(e);                                    /* clean up */
     } else {
-        x = x_strdup("*");
+        x = x_strdup("");   /* called from only one place so this is safe */
     }
 
     return x;                           /* this must be deleted elsewhere */