]> granicus.if.org Git - clang/commitdiff
clang-format: [Java] Improve annotation handling.
authorDaniel Jasper <djasper@google.com>
Tue, 21 Oct 2014 10:58:14 +0000 (10:58 +0000)
committerDaniel Jasper <djasper@google.com>
Tue, 21 Oct 2014 10:58:14 +0000 (10:58 +0000)
Before:
@SuppressWarnings(
    value = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa") public static int iiiiiiiiiiiiiiiiiiiiiiii;

After:
  @SuppressWarnings(value = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
  public static int iiiiiiiiiiiiiiiiiiiiiiii;

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@220284 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJava.cpp

index ba08ace1e8bdcf566f9e4acd6f3a869e6e728d89..9adec611f28ea16951c6b56e6f74a89ce0c16473 100644 (file)
@@ -1817,6 +1817,8 @@ bool TokenAnnotator::canBreakBefore(const AnnotatedLine &Line,
     return false;
   if (Left.Tok.getObjCKeywordID() == tok::objc_interface)
     return false;
+  if (Left.Type == TT_JavaAnnotation)
+    return true;
   if (Right.Type == TT_StartOfName ||
       Right.Type == TT_FunctionDeclarationName || Right.is(tok::kw_operator))
     return true;
index 00809bea91fc968fa429a0d7e0e5bbc426234b0e..afc13cfbf6af2ae6b7c178055d7aeb3e2d3a631e 100644 (file)
@@ -82,6 +82,8 @@ TEST_F(FormatTestJava, Annotations) {
                "});");
 
   verifyFormat("@Partial @Mock DataLoader loader;");
+  verifyFormat("@SuppressWarnings(value = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")\n"
+               "public static int iiiiiiiiiiiiiiiiiiiiiiii;");
 }
 
 TEST_F(FormatTestJava, Generics) {