]> granicus.if.org Git - python/commitdiff
Issue #23032: Fix installer build failures on OS X 10.4 Tiger
authorNed Deily <nad@acm.org>
Thu, 11 Dec 2014 23:55:42 +0000 (15:55 -0800)
committerNed Deily <nad@acm.org>
Thu, 11 Dec 2014 23:55:42 +0000 (15:55 -0800)
by disabling assembly code in the OpenSSL build.

Mac/BuildScript/build-installer.py
Misc/NEWS

index 5c9b5901795869822a615de03ecc4e672c1540e0..6bcdcd8e7e9c51cfa707edd6fe93d08a97e86ad2 100755 (executable)
@@ -844,6 +844,11 @@ def build_universal_openssl(basedir, archList):
     separately then lipo them together into fat libraries.
     """
 
+    # OpenSSL fails to build with Xcode 2.5 (on OS X 10.4).
+    # If we are building on a 10.4.x or earlier system,
+    # unilaterally disable assembly code building to avoid the problem.
+    no_asm = int(platform.release().split(".")[0]) < 9
+
     def build_openssl_arch(archbase, arch):
         "Build one architecture of openssl"
         arch_opts = {
@@ -868,6 +873,8 @@ def build_universal_openssl(basedir, archList):
             "--prefix=%s"%os.path.join("/", *FW_VERSION_PREFIX),
             "--openssldir=/System/Library/OpenSSL",
         ]
+        if no_asm:
+            configure_opts.append("no-asm")
         runCommand(" ".join(["perl", "Configure"]
                         + arch_opts[arch] + configure_opts))
         runCommand("make depend OSX_SDK=%s" % SDKPATH)
index 6f4e5521f8eaee9d9d63f4904b5cb695a05df30a..3f86e90873e001e7b5121c8a9cbf1d7cfbd6518b 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -57,6 +57,12 @@ IDLE
 - Issue #16893: Update Idle doc chapter to match current Idle and add new
   information.
 
+Build
+-----
+
+- Issue #23032: Fix installer build failures on OS X 10.4 Tiger
+  by disabling assembly code in the OpenSSL build.
+
 
 What's New in Python 2.7.9?
 ===========================