]> granicus.if.org Git - clang/commitdiff
[Lex] Speed up updateConsecutiveMacroArgTokens (NFC)
authorVedant Kumar <vsk@apple.com>
Thu, 7 Jul 2016 22:38:29 +0000 (22:38 +0000)
committerVedant Kumar <vsk@apple.com>
Thu, 7 Jul 2016 22:38:29 +0000 (22:38 +0000)
SM.isWrittenInSameFile() calls getFileID(), which can be expensive.
Move this check behind some cheaper filters.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@274800 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Lex/TokenLexer.cpp

index 7f3be700c6829d6fb2689122c6c23562e1974e38..994bae632aec7d2570b63795e6459e3bb150204b 100644 (file)
@@ -787,9 +787,6 @@ static void updateConsecutiveMacroArgTokens(SourceManager &SM,
     if (CurLoc.isFileID() != NextLoc.isFileID())
       break; // Token from different kind of FileID.
 
-    if (CurLoc.isMacroID() && !SM.isWrittenInSameFile(CurLoc, NextLoc))
-      break; // Token from a different macro.
-
     int RelOffs;
     if (!SM.isInSameSLocAddrSpace(CurLoc, NextLoc, &RelOffs))
       break; // Token from different local/loaded location.
@@ -797,6 +794,10 @@ static void updateConsecutiveMacroArgTokens(SourceManager &SM,
     // "characters" away.
     if (RelOffs < 0 || RelOffs > 50)
       break;
+
+    if (CurLoc.isMacroID() && !SM.isWrittenInSameFile(CurLoc, NextLoc))
+      break; // Token from a different macro.
+
     CurLoc = NextLoc;
   }