Fix `DSRecordContent::operator==` hiding virtual `DNSRecordContent::operator==`

Hopefully we should be able to enable `-Woverloaded-virtual` soon.

diff --git a/pdns/dnsrecords.hh b/pdns/dnsrecords.hh
index 97c66d00524716191703f4b37de7cfe2b695f3c8..e3eed1ef27a311cfcbca1c256a28a987352759e6 100644 (file)
--- a/pdns/dnsrecords.hh
+++ b/pdns/dnsrecords.hh
@@ -340,10 +340,13 @@ class DSRecordContent : public DNSRecordContent
 {
 public:
   DSRecordContent();
-  bool operator==(const DSRecordContent& rhs) const
+  bool operator==(const DNSRecordContent& rhs) const override
   {
+    if(typeid(*this) != typeid(rhs))
+      return false;
+    auto rrhs =dynamic_cast<const decltype(this)>(&rhs);
     return tie(d_tag, d_algorithm, d_digesttype, d_digest) ==
-      tie(rhs.d_tag, rhs.d_algorithm, rhs.d_digesttype, rhs.d_digest);
+      tie(rrhs->d_tag, rrhs->d_algorithm, rrhs->d_digesttype, rrhs->d_digest);
   }
   bool operator<(const DSRecordContent& rhs) const
   {