]> granicus.if.org Git - php/commitdiff
fix minor memory leak
authorGreg Beaver <cellog@php.net>
Fri, 24 Jul 2009 16:21:40 +0000 (16:21 +0000)
committerGreg Beaver <cellog@php.net>
Fri, 24 Jul 2009 16:21:40 +0000 (16:21 +0000)
ext/phar/zip.c

index ad1e8b17916af2e43fc57adf5685d04266426654..d7c24ae9896091338ea69e0eb6f83c0d2e596331 100644 (file)
@@ -310,6 +310,9 @@ foundit:
                        if (mydata->metadata) { \
                                zval_dtor(mydata->metadata); \
                        } \
+                       if (mydata->signature) { \
+                               efree(mydata->signature); \
+                       } \
                        if (error) { \
                                spprintf(error, 4096, "phar error: %s in zip-based phar \"%s\"", errmsg, mydata->fname); \
                        } \
@@ -331,6 +334,9 @@ foundit:
                        if (mydata->metadata) { \
                                zval_dtor(mydata->metadata); \
                        } \
+                       if (mydata->signature) { \
+                               efree(mydata->signature); \
+                       } \
                        if (error) { \
                                spprintf(error, 4096, "phar error: %s in zip-based phar \"%s\"", errmsg, mydata->fname); \
                        } \
@@ -766,7 +772,6 @@ static int phar_zip_changed_apply(void *data, void *arg TSRMLS_DC) /* {{{ */
        php_uint32 newcrc32;
        off_t offset;
        int not_really_modified = 0;
-
        entry = (phar_entry_info *)data;
        p = (struct _phar_zip_pass*) arg;