- Fix possible buffer overflow. Always better to use strlcpy() instead

  of strncpy()

diff --git a/ext/curl/curl.c b/ext/curl/curl.c
index 5cdc17b627ad0b501a3e6b5661b5b69abdaff48c..e8b4a15200a5f0e02b0291de5aa42af8ce139303 100644 (file)
--- a/ext/curl/curl.c
+++ b/ext/curl/curl.c
@@ -444,7 +444,7 @@ static size_t _php_curl_passwd(void *ctx, char *prompt, char *buf, int buflen)
                return -1;
        }
 
-       strncpy(buf, Z_STRVAL_P(retval), Z_STRLEN_P(retval));
+       strlcpy(buf, Z_STRVAL_P(retval), buflen);
 
        zval_ptr_dtor(&argv[0]);
        zval_ptr_dtor(&argv[1]);