]> granicus.if.org Git - vim/commitdiff
patch 9.0.0367: Coverity complains about dropping sign of character v9.0.0367
authorBram Moolenaar <Bram@vim.org>
Sat, 3 Sep 2022 11:53:20 +0000 (12:53 +0100)
committerBram Moolenaar <Bram@vim.org>
Sat, 3 Sep 2022 11:53:20 +0000 (12:53 +0100)
Problem:    Coverity complains about dropping sign of character.
Solution:   Add explicit type cast.

src/spellfile.c
src/version.c

index 7620affee8e9ce0444c8cfec5fd535f38336e2c8..8b6388fb50e152fc0042fb6f06adbf0b8958753b 100644 (file)
@@ -404,7 +404,7 @@ spell_load_file(
      * <HEADER>: <fileID>
      */
     for (i = 0; i < VIMSPELLMAGICL; ++i)
-       buf[i] = getc(fd);                              // <fileID>
+       buf[i] = (unsigned)getc(fd);                    // <fileID>
     if (STRNCMP(buf, VIMSPELLMAGIC, VIMSPELLMAGICL) != 0)
     {
        emsg(_(e_this_does_not_look_like_spell_file));
@@ -700,7 +700,7 @@ suggest_load_files(void)
             * <SUGHEADER>: <fileID> <versionnr> <timestamp>
             */
            for (i = 0; i < VIMSUGMAGICL; ++i)
-               buf[i] = getc(fd);                      // <fileID>
+               buf[i] = (unsigned)getc(fd);            // <fileID>
            if (STRNCMP(buf, VIMSUGMAGIC, VIMSUGMAGICL) != 0)
            {
                semsg(_(e_this_does_not_look_like_sug_file_str),
@@ -845,7 +845,7 @@ read_region_section(FILE *fd, slang_T *lp, int len)
     if (len > MAXREGIONS * 2)
        return SP_FORMERROR;
     for (i = 0; i < len; ++i)
-       lp->sl_regions[i] = getc(fd);                   // <regionname>
+       lp->sl_regions[i] = (unsigned)getc(fd);         // <regionname>
     lp->sl_regions[len] = NUL;
     return 0;
 }
@@ -925,7 +925,7 @@ read_prefcond_section(FILE *fd, slang_T *lp)
            buf[0] = '^';           // always match at one position only
            p = buf + 1;
            while (n-- > 0)
-               *p++ = getc(fd);                        // <condstr>
+               *p++ = (unsigned)getc(fd);              // <condstr>
            *p = NUL;
            lp->sl_prefprog[i] = vim_regcomp(buf, RE_MAGIC + RE_STRING);
        }
@@ -1063,7 +1063,7 @@ read_sal_section(FILE *fd, slang_T *slang)
            // store the char we got while checking for end of sm_lead
            *p++ = c;
        for (++i; i < ccnt; ++i)
-           *p++ = getc(fd);                    // <salfrom>
+           *p++ = (unsigned)getc(fd);                  // <salfrom>
        *p++ = NUL;
 
        // <saltolen> <salto>
index 1c685d1394741d2a7d5f08e2b932d5201e6de383..e8f40e4c7f32b6a391264246ca8916def16c01f1 100644 (file)
@@ -707,6 +707,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    367,
 /**/
     366,
 /**/