More idlelib cleanup inspired by pyflakes.

diff --git a/Lib/idlelib/SearchEngine.py b/Lib/idlelib/SearchEngine.py
index da42bd9ea1efa6d95bf5f194346984fbf116e50c..099cb09dd5f36ae3944089a05c71a5b9539d1592 100644 (file)
--- a/Lib/idlelib/SearchEngine.py
+++ b/Lib/idlelib/SearchEngine.py
@@ -85,7 +85,7 @@ class SearchEngine:
         except re.error as what:
             args = what.args
             msg = args[0]
-            col = arg[1] if len(args) >= 2 else -1
+            col = args[1] if len(args) >= 2 else -1
             self.report_error(pat, msg, col)
             return None
         return prog

diff --git a/Lib/idlelib/StackViewer.py b/Lib/idlelib/StackViewer.py
index ed2c9e75c596aee2b5cedd498e3f89e226eeb049..b1e5e2674275e53fcf8069fd4f686ce37ac86db6 100644 (file)
--- a/Lib/idlelib/StackViewer.py
+++ b/Lib/idlelib/StackViewer.py
@@ -131,8 +131,8 @@ def _stack_viewer(parent):
     root.geometry("+%d+%d"%(x, y + 150))
     flist = PyShellFileList(root)
     try: # to obtain a traceback object
-        a
-    except:
+        intentional_name_error
+    except NameError:
         exc_type, exc_value, exc_tb = sys.exc_info()
 
     # inject stack trace to sys

diff --git a/Lib/idlelib/idle_test/test_textview.py b/Lib/idlelib/idle_test/test_textview.py
index a9b60ca832fe2227754beedbb5fd23b8772e8bb7..68e5b82ad912ad9231d80fa819dbbbf7b82a4a46 100644 (file)
--- a/Lib/idlelib/idle_test/test_textview.py
+++ b/Lib/idlelib/idle_test/test_textview.py
@@ -12,7 +12,7 @@ requires('gui')
 
 import unittest
 import os
-from tkinter import Tk, Text, TclError
+from tkinter import Tk
 from idlelib import textView as tv
 from idlelib.idle_test.mock_idle import Func
 from idlelib.idle_test.mock_tk import Mbox
@@ -23,7 +23,7 @@ def setUpModule():
 
 def tearDownModule():
     global root
-    root.destroy()
+    root.destroy()  # pyflakes falsely sees root as undefined
     del root