ICU-21747 Upgrade WarningsAsErrors build bot to Clang-13 on Ubuntu 20.04

diff --git a/.ci-builds/.azure-pipelines.yml b/.ci-builds/.azure-pipelines.yml
index e8a35ac9703f5839bf65cef73b3764f31374104c..e9ea5e52293387f3c0501446efcbdbca5bea40c7 100644 (file)
--- a/.ci-builds/.azure-pipelines.yml
+++ b/.ci-builds/.azure-pipelines.yml
@@ -45,21 +45,28 @@ jobs:
         cd icu4c/source/test/cintltst && LANG=C.UTF-8 LD_LIBRARY_PATH=../../lib:../../tools/ctestfw ./cintltst /tsutil/cloctst/TestCDefaultLocale
       displayName: 'Test C.UTF-8 Default locale'
 #-------------------------------------------------------------------------
-- job: ICU4C_Clang_Ubuntu_1804_WarningsAsErrors
-  displayName: 'C: Linux Clang WarningsAsErrors (Ubuntu 18.04)'
+- job: ICU4C_Clang13_Ubuntu_2004_WarningsAsErrors
+  displayName: 'C: Linux Clang-13 WarningsAsErrors (Ubuntu 20.04)'
   timeoutInMinutes: 30
   pool:
-    vmImage: 'ubuntu-18.04'
+    vmImage: 'ubuntu-20.04'
   steps:
     - checkout: self
       lfs: true
       fetchDepth: 10
+    # Install Clang-13 from https://apt.llvm.org/
+    - script: |
+        curl -Ls https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
+        sudo apt-add-repository 'deb http://apt.llvm.org/focal/ llvm-toolchain-focal-13 main'
+        sudo apt update
+        sudo apt install -qy clang-13 lld-13 libc++-13-dev libc++abi-13-dev
+      displayName: 'Install Clang-13'
     - script: |
         export CPPFLAGS="-Werror -Wall -Wextra -Wextra-semi -Wundef -Wnon-virtual-dtor" && cd icu4c/source && ./runConfigureICU Linux && make -j2 tests
       displayName: 'Build only (WarningsAsErrors)'
       env:
-        CC: clang
-        CXX: clang++
+        CC: clang-13
+        CXX: clang++-13
 #-------------------------------------------------------------------------
 - job: ICU4C_Clang_Ubuntu_DataFilter_1804
   displayName: 'C: Linux Clang DataFilter (Ubuntu 18.04)'

diff --git a/icu4c/source/test/intltest/rbbitst.cpp b/icu4c/source/test/intltest/rbbitst.cpp
index b8424ac6c19883d541455a4ab7b64c568af224c7..742f029652a3818a0c3a96015d7956e441750cce 100644 (file)
--- a/icu4c/source/test/intltest/rbbitst.cpp
+++ b/icu4c/source/test/intltest/rbbitst.cpp
@@ -4014,6 +4014,7 @@ void RBBITest::RunMonkey(BreakIterator *bi, RBBIMonkeyKind &mk, const char *name
                 errln("breakPos > testText.length()");
             }
             expectedBreaks[breakPos] = 1;
+            expectedCount++;
             U_ASSERT(expectedCount<testText.length());
         }
 

diff --git a/icu4c/source/tools/genrb/wrtxml.cpp b/icu4c/source/tools/genrb/wrtxml.cpp
index e65cd768d7c6b440fdec8953a259927d5eaf627e..fa2105d908e7988bfebe0305fc8c89e29eebfb8c 100644 (file)
--- a/icu4c/source/tools/genrb/wrtxml.cpp
+++ b/icu4c/source/tools/genrb/wrtxml.cpp
@@ -924,8 +924,6 @@ bin_write_xml(BinaryResource *res, const char* id, const char* /*language*/, UEr
 static void
 table_write_xml(TableResource *res, const char* id, const char* language, UBool isTopLevel, UErrorCode *status) {
 
-    uint32_t  i         = 0;
-
     struct SResource *current = NULL;
     char* sid = NULL;
 
@@ -940,7 +938,6 @@ table_write_xml(TableResource *res, const char* id, const char* language, UBool
     }
 
     current = res->fFirst;
-    i = 0;
 
     while (current != NULL) {
         res_write_xml(current, sid, language, FALSE, status);
@@ -949,7 +946,6 @@ table_write_xml(TableResource *res, const char* id, const char* language, UBool
             return;
         }
 
-        i += 1;
         current = current->fNext;
     }