Fixed: 'dereference before null check' in stack.c

The pointer `theStack` is dereferenced before the if statement that
checks whether `theStack` is null. This is fixed by placing the variable
declarations in the if statement.

diff --git a/lib/rbtree/stack.c b/lib/rbtree/stack.c
index b269b937a12352c5024e0fc0d18598107ad3c320..1b93b9d99caf7d3b748ffac8c928e847c3ae5e82 100755 (executable)
--- a/lib/rbtree/stack.c
+++ b/lib/rbtree/stack.c
@@ -69,10 +69,9 @@ DATA_TYPE StackPop(stk_stack * theStack) {
 }
 
 void StackDestroy(stk_stack * theStack,void DestFunc(void * a)) {
-  stk_stack_node * x=theStack->top;
-  stk_stack_node * y;
-
   if(theStack) {
+    stk_stack_node * x=theStack->top;
+    stk_stack_node * y;
     while(x) {
       y=x->next;
       DestFunc(x->info);