[trunk]formatted some messages. Removed -version option to disambiguate

with -v(erbose) option, added version info in help display

diff --git a/src/bin/jp2/opj_compress.c b/src/bin/jp2/opj_compress.c
index 4da8eaeec68855eb88e35cb711a3f98b0796a167..dc27fb62147d2a5f2bf8b0d51faac00fd7edb408 100644 (file)
--- a/src/bin/jp2/opj_compress.c
+++ b/src/bin/jp2/opj_compress.c
@@ -86,7 +86,9 @@ typedef struct img_folder{
 }img_fol_t;
 
 static void encode_help_display(void) {
-    fprintf(stdout,"HELP for opj_compress\n----\n\n");
+    fprintf(stdout,"This is the opj_compress utility from the OpenJPEG project.\n"
+            "It has been compiled against openjp2 library v%s.\n\n",opj_version());
+    fprintf(stdout,"HELP\n----\n\n");
     fprintf(stdout,"- the -h option displays this help information on screen\n\n");
 
     /* UniPG>> */
@@ -467,8 +469,7 @@ static int parse_cmdline_encoder(int argc, char **argv, opj_cparameters_t *param
         {"POC",REQ_ARG, NULL ,'P'},
         {"ROI",REQ_ARG, NULL ,'R'},
         {"jpip",NO_ARG, NULL, 'J'},
-        {"mct",REQ_ARG, NULL, 'Y'},
-        {"version",NO_ARG, NULL, 'v'}
+        {"mct",REQ_ARG, NULL, 'Y'}
     };
 
     /* parse the command line */
@@ -476,7 +477,7 @@ static int parse_cmdline_encoder(int argc, char **argv, opj_cparameters_t *param
         #ifdef USE_JPWL
             "W:"
         #endif /* USE_JPWL */
-            "hv";
+            "h";
 
     totlen=sizeof(long_option);
     img_fol->set_out_format=0;
@@ -843,13 +844,6 @@ static int parse_cmdline_encoder(int argc, char **argv, opj_cparameters_t *param
 
             /* ----------------------------------------------------- */
 
-        case 'v':                      /* display the openjpeg library version in use */
-            fprintf(stdout,"This is the opj_compress utility from the OpenJPEG project.\n"
-                    "It has been compiled against openjp2 library v%s.\n",opj_version());
-            return 1;
-
-            /* ----------------------------------------------------- */
-
         case 'P':                      /* POC */
         {
             int numpocs = 0;           /* number of progression order change (POC) default 0 */

diff --git a/src/bin/jp2/opj_decompress.c b/src/bin/jp2/opj_decompress.c
index 78957e852ab4e4a7bd4eb81dbe4201ace0f8c9fd..4e4967df95864fc1126941d81218b6688df5ebe1 100644 (file)
--- a/src/bin/jp2/opj_decompress.c
+++ b/src/bin/jp2/opj_decompress.c
@@ -106,9 +106,10 @@ int parse_DA_values( char* inArg, unsigned int *DA_x0, unsigned int *DA_y0, unsi
 
 /* -------------------------------------------------------------------------- */
 static void decode_help_display(void) {
-       fprintf(stdout,"HELP for opj_decompress\n----\n\n");
+    fprintf(stdout,"This is the opj_decompress utility from the OpenJPEG project.\n"
+            "It has been compiled against openjp2 library v%s.\n\n",opj_version());
+    fprintf(stdout,"HELP\n----\n\n");
        fprintf(stdout,"- the -h option displays this help information on screen\n\n");
-
 /* UniPG>> */
        fprintf(stdout,"List of parameters for the JPEG 2000 "
 #ifdef USE_JPWL
@@ -331,8 +332,7 @@ int parse_cmdline_decoder(int argc, char **argv, opj_dparameters_t *parameters,i
        int totlen, c;
        opj_option_t long_option[]={
                {"ImgDir",REQ_ARG, NULL ,'y'},
-               {"OutFor",REQ_ARG, NULL ,'O'},
-        {"version",NO_ARG, NULL ,'v'}
+        {"OutFor",REQ_ARG, NULL ,'O'}
        };
 
        const char optlist[] = "i:o:r:l:x:d:t:"
@@ -342,7 +342,7 @@ int parse_cmdline_decoder(int argc, char **argv, opj_dparameters_t *parameters,i
                                        "W:"
 #endif /* USE_JPWL */
 /* <<UniPG */
-            "hv"               ;
+            "h"                ;
        totlen=sizeof(long_option);
        img_fol->set_out_format = 0;
        do {
@@ -474,13 +474,6 @@ int parse_cmdline_decoder(int argc, char **argv, opj_dparameters_t *parameters,i
                                decode_help_display();
                                return 1;                               
 
-                /* ------------------------------------------------------ */
-
-             case 'v':                 /* display the openjpeg library version in use */
-            fprintf(stdout,"This is the opj_decompress utility from the OpenJPEG project.\n"
-                    "It has been compiled against openjp2 library v%s.\n",opj_version());
-            return 1;
-
             /* ----------------------------------------------------- */
 
                        case 'y':                       /* Image Directory path */
@@ -599,7 +592,7 @@ int parse_cmdline_decoder(int argc, char **argv, opj_dparameters_t *parameters,i
                                /* ----------------------------------------------------- */
                        
         default:
-            fprintf(stderr, "[WARNING] An invalid option has been ignored\n");
+            fprintf(stderr, "[WARNING] An invalid option has been ignored.\n");
             break;
                }
        }while(c != -1);
@@ -607,16 +600,17 @@ int parse_cmdline_decoder(int argc, char **argv, opj_dparameters_t *parameters,i
        /* check for possible errors */
        if(img_fol->set_imgdir==1){
                if(!(parameters->infile[0]==0)){
-            fprintf(stderr, "[ERROR] options -ImgDir and -i cannot be used together !!\n");
+            fprintf(stderr, "[ERROR] options -ImgDir and -i cannot be used together.\n");
                        return 1;
                }
                if(img_fol->set_out_format == 0){
-            fprintf(stderr, "[ERROR] When -ImgDir is used, -OutFor <FORMAT> must be used !!\n");
-                       fprintf(stderr, "Only one format allowed! Valid format PGM, PPM, PNM, PGX, BMP, TIF, RAW and TGA!!\n");
+            fprintf(stderr, "[ERROR] When -ImgDir is used, -OutFor <FORMAT> must be used.\n");
+            fprintf(stderr, "Only one format allowed.\n"
+                            "Valid format are PGM, PPM, PNM, PGX, BMP, TIF, RAW and TGA.\n");
                        return 1;
                }
                if(!((parameters->outfile[0] == 0))){
-            fprintf(stderr, "[ERROR] options -ImgDir and -o cannot be used together !!\n");
+            fprintf(stderr, "[ERROR] options -ImgDir and -o cannot be used together.\n");
                        return 1;
                }
        }else{

diff --git a/src/bin/jp2/opj_dump.c b/src/bin/jp2/opj_dump.c
index 7a841d536383b39aa88a9c01c25b0a2c331271fe..c40f36868019c0a27f177834870b337f894a63de 100644 (file)
--- a/src/bin/jp2/opj_dump.c
+++ b/src/bin/jp2/opj_dump.c
@@ -91,7 +91,9 @@ static int parse_cmdline_decoder(int argc, char **argv, opj_dparameters_t *param
 
 /* -------------------------------------------------------------------------- */
 static void decode_help_display(void) {
-       fprintf(stdout,"HELP for opj_dump\n----\n\n");
+    fprintf(stdout,"This is the opj_dump utility from the OpenJPEG project.\n"
+            "It has been compiled against openjp2 library v%s.\n\n",opj_version());
+    fprintf(stdout,"HELP\n----\n\n");
        fprintf(stdout,"- the -h option displays this help information on screen\n\n");
 
 /* UniPG>> */
@@ -99,7 +101,7 @@ static void decode_help_display(void) {
 #ifdef USE_JPWL
                "+ JPWL "
 #endif /* USE_JPWL */
-               "decoder:\n");
+        "dump utility:\n");
 /* <<UniPG */
        fprintf(stdout,"\n");
        fprintf(stdout,"\n");
@@ -113,10 +115,10 @@ static void decode_help_display(void) {
        fprintf(stdout,"    OPTIONAL\n");
        fprintf(stdout,"    Output file where file info will be dump.\n");
        fprintf(stdout,"    By default it will be in the stdout.\n");
-       fprintf(stdout,"  -v "); /* FIXME WIP_MSD */
+    fprintf(stdout,"  -quiet "); /* FIXME WIP_MSD */
        fprintf(stdout,"    OPTIONAL\n");
-       fprintf(stdout,"    Activate or not the verbose mode (display info and warning message)\n");
-       fprintf(stdout,"    By default verbose mode is off.\n");
+    fprintf(stdout,"    Suppress informative messages\n");
+    fprintf(stdout,"    By default verbose mode is on.\n");
        fprintf(stdout,"\n");
 }
 
@@ -277,9 +279,9 @@ static int infile_format(const char *fname)
 static int parse_cmdline_decoder(int argc, char **argv, opj_dparameters_t *parameters,img_fol_t *img_fol) {
        int totlen, c;
        opj_option_t long_option[]={
-               {"ImgDir",REQ_ARG, NULL ,'y'},
+        {"ImgDir",REQ_ARG, NULL ,'y'}
        };
-       const char optlist[] = "i:o:f:hv";
+    const char optlist[] = "i:o:f:hv";
 
        totlen=sizeof(long_option);
        img_fol->set_out_format = 0;
@@ -341,38 +343,40 @@ static int parse_cmdline_decoder(int argc, char **argv, opj_dparameters_t *param
 
                        /* ----------------------------------------------------- */
 
-                       case 'v':               /* Verbose mode */
+            case 'v':                  /* Verbose mode */
                        {
-                               parameters->m_verbose = 1;
+                parameters->m_verbose = 1;
                        }
                        break;
                        
                                /* ----------------------------------------------------- */
-                       default:
-                               fprintf(stderr,"WARNING -> this option is not valid \"-%c %s\"\n",c, opj_optarg);
-                               break;
-               }
+        default:
+            fprintf(stderr, "[WARNING] An invalid option has been ignored.\n");
+            break;
+        }
        }while(c != -1);
 
        /* check for possible errors */
        if(img_fol->set_imgdir==1){
                if(!(parameters->infile[0]==0)){
-                       fprintf(stderr, "Error: options -ImgDir and -i cannot be used together !!\n");
+            fprintf(stderr, "[ERROR] options -ImgDir and -i cannot be used together.\n");
                        return 1;
                }
                if(img_fol->set_out_format == 0){
-                       fprintf(stderr, "Error: When -ImgDir is used, -OutFor <FORMAT> must be used !!\n");
-                       fprintf(stderr, "Only one format allowed! Valid format PGM, PPM, PNM, PGX, BMP, TIF, RAW and TGA!!\n");
+            fprintf(stderr, "[ERROR] When -ImgDir is used, -OutFor <FORMAT> must be used.\n");
+            fprintf(stderr, "Only one format allowed.\n"
+                            "Valid format are PGM, PPM, PNM, PGX, BMP, TIF, RAW and TGA.\n");
                        return 1;
                }
                if(!(parameters->outfile[0] == 0)){
-                       fprintf(stderr, "Error: options -ImgDir and -o cannot be used together !!\n");
+            fprintf(stderr, "[ERROR] options -ImgDir and -o cannot be used together\n");
                        return 1;
                }
        }else{
                if(parameters->infile[0] == 0) {
+            fprintf(stderr, "[ERROR] Required parameter is missing\n");
                        fprintf(stderr, "Example: %s -i image.j2k\n",argv[0]);
-                       fprintf(stderr, "    Try: %s -h\n",argv[0]);
+            fprintf(stderr, "   Help: %s -h\n",argv[0]);
                        return 1;
                }
        }

diff --git a/src/lib/openjp2/j2k.c b/src/lib/openjp2/j2k.c
index 677a0b6197fe1bc28fa2a64ef43b03071de91577..858bb39f359b1a27753d2cfeebc755871cd2b6e1 100644 (file)
--- a/src/lib/openjp2/j2k.c
+++ b/src/lib/openjp2/j2k.c
@@ -6039,7 +6039,7 @@ void opj_j2k_set_cinema_parameters(opj_cparameters_t *parameters, opj_image_t *i
     }
 
     parameters->tcp_rates[0] = (OPJ_FLOAT32) (image->numcomps * image->comps[0].w * image->comps[0].h * image->comps[0].prec)/
-            (OPJ_FLOAT32)(parameters->max_cs_size * 8 * image->comps[0].dx * image->comps[0].dy);
+            (OPJ_FLOAT32)(((OPJ_UINT32)parameters->max_cs_size) * 8 * image->comps[0].dx * image->comps[0].dy);
 
 }