properly handle malloc failure (closes #24044)

Patch by Christian Heimes.

diff --git a/Misc/NEWS b/Misc/NEWS
index b54f267083275f5bc4c0dcc77973d88c427876a8..895ff67403f495c25fa963e7abbde792f3bd8c18 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@ What's New in Python 3.2.7?
 Core and Builtins
 -----------------
 
+- Issue #24044: Fix possible null pointer dereference in list.sort in out of
+  memory conditions.
+
 - Issue #23055: Fixed a buffer overflow in PyUnicode_FromFormatV.  Analysis
   and fix by Guido Vranken.
 

diff --git a/Objects/listobject.c b/Objects/listobject.c
index b9ef0d0287f42b645d6df831226441d16880fab6..3642b39dd132f6402f0ffe30c0e91bd01f8540ec 100644 (file)
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -1924,8 +1924,10 @@ listsort(PyListObject *self, PyObject *args, PyObject *kwds)
             keys = &ms.temparray[saved_ob_size+1];
         else {
             keys = PyMem_MALLOC(sizeof(PyObject *) * saved_ob_size);
-            if (keys == NULL)
-                return NULL;
+            if (keys == NULL) {
+                PyErr_NoMemory();
+                goto keyfunc_fail;
+            }
         }
 
         for (i = 0; i < saved_ob_size ; i++) {