* libmisc/sulog.c: Ignore the return value of umask() when the

	mask is restored.
	* libmisc/sulog.c: Add brackets.
	* libmisc/sulog.c: Ignore return value of time() when use with a
	non NULL argument.

diff --git a/ChangeLog b/ChangeLog
index 6326af00538dea3336b28c3d13765679e9d1ea97..828b33b8b0ee9273c4f19cd1be93485d8c6bac01 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2008-06-13  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * libmisc/sulog.c: Ignore the return value of umask() when the
+       mask is restored.
+       * libmisc/sulog.c: Add brackets.
+       * libmisc/sulog.c: Ignore return value of time() when use with a
+       non NULL argument.
+
 2008-06-13  Nicolas François  <nicolas.francois@centraliens.net>
 
        * libmisc/log.c: Avoid assignments in comparisons.

diff --git a/libmisc/sulog.c b/libmisc/sulog.c
index bb1d2a5edb50bd4dc7ef3896d614ea6498bca260..a06647952b3c6c9f3cfac314e24e447a506b9743 100644 (file)
--- a/libmisc/sulog.c
+++ b/libmisc/sulog.c
@@ -76,7 +76,7 @@ void sulog (const char *tty, bool success, const char *oldname, const char *name
                oldgid = 0;
        }
        fp = fopen (sulog_file, "a+");
-       umask (oldmask);
+       (void) umask (oldmask);
        if ((oldgid != 0) && (setgid (oldgid) != 0)) {
                perror ("setgid");
                SYSLOG ((LOG_ERR,
@@ -85,10 +85,11 @@ void sulog (const char *tty, bool success, const char *oldname, const char *name
                /* Do not return if the group permission were raised. */
                exit (1);
        }
-       if (fp == (FILE *) 0)
+       if (fp == (FILE *) 0) {
                return;         /* can't open or create logfile */
+       }
 
-       time (&now);
+       (void) time (&now);
        tm = localtime (&now);
 
        fprintf (fp, "SU %.02d/%.02d %.02d:%.02d %c %s %s-%s\n",