]> granicus.if.org Git - libevent/commitdiff
test/et/et: use evutil_socket_t* over int* for pointer to the pair
authorAzat Khuzhin <azat@libevent.org>
Tue, 29 Jan 2019 18:06:37 +0000 (21:06 +0300)
committerAzat Khuzhin <azat@libevent.org>
Tue, 29 Jan 2019 18:11:27 +0000 (21:11 +0300)
Next code will not work correctly under win x64:
  evutil_socket_t very_long_pair_name[2];
  int *pair = very_long_pair_name; // <-- accessing the second word of the first element

Because sizeof(evutil_socket_t) == sizeof(intptr_t) == 8

P.S. in the 5334762f another test had been fixed instead of the one that
really fails.

Fixes: 5334762f ("test/et/et: fix it by using appropriate type for the SOCKET (evutil_socket_t)")
Refs: #750

test/regress_et.c

index 4c7dc45ff688ffaeeda222a245f2119be06a54ad..5fa87a399af29a719fc9420a49bb35c6730adadc 100644 (file)
@@ -80,7 +80,7 @@ test_edgetriggered(void *data_)
 {
        struct basic_test_data *data = data_;
        struct event_base *base = data->base;
-       int *pair = data->pair;
+       evutil_socket_t *pair = data->pair;
        struct event *ev = NULL;
        const char *test = "test string";
        int supports_et;