Don't automatically set the QR flag in case of HeaderModify

Some actions are actually altering the query and not turning it
into an answer (NoRecurse, DisableValidation).
All the actions that do turn it into an answer are already setting
the QR flag themselves.

diff --git a/pdns/dnsdist-tcp.cc b/pdns/dnsdist-tcp.cc
index 51ecb73b27f9febe6d22e64101c75925150c2fd1..ee25798cb8a16526559124241527e85b05c8d3fa 100644 (file)
--- a/pdns/dnsdist-tcp.cc
+++ b/pdns/dnsdist-tcp.cc
@@ -256,7 +256,6 @@ void* tcpClientThread(int pipefd)
        case DNSAction::Action::Spoof:
          ;
        case DNSAction::Action::HeaderModify:
-         dh->qr=true;
          break;
        case DNSAction::Action::Allow:
        case DNSAction::Action::None:

diff --git a/pdns/dnsdist.cc b/pdns/dnsdist.cc
index 673d7016f8be75dc7b1c9b24a02705b436f5dfec..50a3146f2566c4a605b188595a1ffca21e64a866 100644 (file)
--- a/pdns/dnsdist.cc
+++ b/pdns/dnsdist.cc
@@ -633,7 +633,6 @@ try
       case DNSAction::Action::Spoof:
        ;
       case DNSAction::Action::HeaderModify:
-       dh->qr=true;
        break;
       case DNSAction::Action::Delay:
        delayMsec = static_cast<int>(pdns_stou(ruleresult)); // sorry