Issue #17582: xml.etree.ElementTree nows preserves whitespaces in attributes

(Patch by Duane Griffin.  Reviewed and approved by Stefan Behnel.)

diff --git a/Lib/test/test_xml_etree.py b/Lib/test/test_xml_etree.py
index bc1dd1461bea37f4b8b04e62b7d6ec86d572df37..fbfc0b0250d5570d1e809004513300d7bebd6d96 100644 (file)
--- a/Lib/test/test_xml_etree.py
+++ b/Lib/test/test_xml_etree.py
@@ -405,6 +405,14 @@ class ElementTreeTest(unittest.TestCase):
         self.assertEqual(ET.tostring(elem),
                 b'<test testa="testval" testb="test1" testc="test2">aa</test>')
 
+        elem = ET.Element('test')
+        elem.set('a', '\r')
+        elem.set('b', '\r\n')
+        elem.set('c', '\t\n\r ')
+        elem.set('d', '\n\n')
+        self.assertEqual(ET.tostring(elem),
+                b'<test a="&#10;" b="&#10;" c="&#09;&#10;&#10; " d="&#10;&#10;" />')
+
     def test_makeelement(self):
         # Test makeelement handling.
 

diff --git a/Lib/xml/etree/ElementTree.py b/Lib/xml/etree/ElementTree.py
index 6d1b0ab864ccc4c1912cc8e3b242020db58e045f..92821c5706268a27972b1e1abd3ea4baa44b2c69 100644 (file)
--- a/Lib/xml/etree/ElementTree.py
+++ b/Lib/xml/etree/ElementTree.py
@@ -1083,8 +1083,19 @@ def _escape_attrib(text):
             text = text.replace(">", ">")
         if "\"" in text:
             text = text.replace("\"", """)
+        # The following business with carriage returns is to satisfy
+        # Section 2.11 of the XML specification, stating that 
+        # CR or CR LN should be replaced with just LN
+        # http://www.w3.org/TR/REC-xml/#sec-line-ends
+        if "\r\n" in text:
+            text = text.replace("\r\n", "\n")
+        if "\r" in text:
+            text = text.replace("\r", "\n")
+        #The following four lines are issue 17582
         if "\n" in text:
             text = text.replace("\n", "
")
+        if "\t" in text:
+            text = text.replace("\t", "	")
         return text
     except (TypeError, AttributeError):
         _raise_serialization_error(text)

diff --git a/Misc/NEWS b/Misc/NEWS
index 43f8f25ed5173e6f6c1400bf6fb422aed4fec896..1dc5ad898ca66ab0237578b3dac4115e597722b9 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -83,6 +83,9 @@ Library
 
 - Issue #24594: Validates persist parameter when opening MSI database
 
+- Issue #17582: xml.etree.ElementTree nows preserves whitespaces in attributes
+  (Patch by Duane Griffin.  Reviewed and approved by Stefan Behnel.)
+
 - Issue #28047: Fixed calculation of line length used for the base64 CTE
   in the new email policies.