]> granicus.if.org Git - clang/commitdiff
Comment fix: change a question to an answer.
authorEli Friedman <eli.friedman@gmail.com>
Wed, 4 Mar 2009 04:22:58 +0000 (04:22 +0000)
committerEli Friedman <eli.friedman@gmail.com>
Wed, 4 Mar 2009 04:22:58 +0000 (04:22 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@66010 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/CGDecl.cpp

index 91071afeb800a0557723fd316c5c804135bef768..3a4ef9535046ca6a47fad78f53896e0c113ccc91 100644 (file)
@@ -127,11 +127,9 @@ void CodeGenFunction::EmitStaticBlockVarDecl(const VarDecl &D) {
         GenerateStaticCXXBlockVarDeclInit(D, GV);
     } else {
       // The initializer may differ in type from the global. Rewrite
-      // the global to match the initializer!?
-      //
-      // FIXME: This matches what we have been doing historically, but
-      // it seems bad. Shouldn't the init expression have the right
-      // type?
+      // the global to match the initializer.  (We have to do this
+      // because some types, like unions, can't be completely represented
+      // in the LLVM type system.)
       if (GV->getType() != Init->getType()) {
         llvm::GlobalVariable *OldGV = GV;