fsync backup_label after pg_start_backup()

Dave Kerr, backpatched by Simon Riggs

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 47d11b945bd7043c1fc83d4392b98f6e15749908..88f2b3944390bcb5d853f8f1aa58d0866d88464a 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -6634,7 +6634,7 @@ pg_start_backup(PG_FUNCTION_ARGS)
                                checkpointloc.xlogid, checkpointloc.xrecoff);
                fprintf(fp, "START TIME: %s\n", strfbuf);
                fprintf(fp, "LABEL: %s\n", backupidstr);
-               if (fflush(fp) || ferror(fp) || FreeFile(fp))
+               if (fflush(fp) || ferror(fp) || pg_fsync(fileno(fp)) != 0 || FreeFile(fp))
                        ereport(ERROR,
                                        (errcode_for_file_access(),
                                         errmsg("could not write file \"%s\": %m",