]> granicus.if.org Git - php/commitdiff
Disabled calling dtors on tsrm_shutdown - calling dtors in tsrm_shutdown makes
authorStanislav Malyshev <stas@php.net>
Tue, 30 Mar 2004 16:56:01 +0000 (16:56 +0000)
committerStanislav Malyshev <stas@php.net>
Tue, 30 Mar 2004 16:56:01 +0000 (16:56 +0000)
modules registering TSRM ids to crash, if they have dtors, since the module
is unloaded before tsrm_shutdown is called. Can be re-enabled after
tsrm_free_id is implemented.

TSRM/TSRM.c

index 112d3cf5c4b65fd33c0c44db177515336be31f7c..b3e5c9b587e4b33386145f995f8665818e55e263 100644 (file)
@@ -158,9 +158,17 @@ TSRM_API void tsrm_shutdown(void)
 
                                next_p = p->next;
                                for (j=0; j<p->count; j++) {
+                               /*
+                                       Disabled calling dtors on tsrm_shutdown - calling dtors
+                                       in tsrm_shutdown makes modules registering TSRM ids 
+                                       to crash, if they have dtors, since the module is unloaded
+                                       before tsrm_shutdown is called. Can be re-enabled after 
+                                       tsrm_free_id is implemented.
+
                                        if (resource_types_table && resource_types_table[j].dtor) {
                                                resource_types_table[j].dtor(p->storage[j], &p->storage);
                                        }
+                                       */
                                        free(p->storage[j]);
                                }
                                free(p->storage);