]> granicus.if.org Git - clang/commitdiff
Revert 124633. The linker has been told how to merge available_externally.
authorRafael Espindola <rafael.espindola@gmail.com>
Tue, 1 Feb 2011 05:45:26 +0000 (05:45 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Tue, 1 Feb 2011 05:45:26 +0000 (05:45 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@124651 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/visibility-hidden-extern-templates.cpp

index 00db261649825192f3df40867ae7467dbc8d23d3..b8f91b464ddac50f509675c4a4e0e7a9cec34582 100644 (file)
@@ -174,7 +174,8 @@ void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV,
 
   // Set visibility for definitions.
   NamedDecl::LinkageInfo LV = D->getLinkageAndVisibility();
-  GV->setVisibility(GetLLVMVisibility(LV.visibility()));
+  if (LV.visibilityExplicit() || !GV->hasAvailableExternallyLinkage())
+    GV->setVisibility(GetLLVMVisibility(LV.visibility()));
 }
 
 /// Set the symbol visibility of type information (vtable and RTTI)
index eb87ff156721ce6854defb38f7e3a9113dfb57a0..7629b77c2ceef4e212f52a96e6c85b0b2612625f 100644 (file)
@@ -20,7 +20,7 @@ void test_X(X<int> xi, X<char> xc) {
   xi.g();
   // CHECK: declare void @_ZN1XIcE1fEv
   xc.f();
-  // CHECK: define available_externally hidden void @_ZN1XIcE1gEv
+  // CHECK: define available_externally void @_ZN1XIcE1gEv
   xc.g();
 }