]> granicus.if.org Git - pdns/commitdiff
rec: Use `cend()` instead of `end()` when comparing with a const iterator
authorRemi Gacogne <remi.gacogne@powerdns.com>
Sat, 25 Mar 2017 09:12:36 +0000 (10:12 +0100)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Sat, 25 Mar 2017 09:12:36 +0000 (10:12 +0100)
Reported by Coverity.

pdns/pdns_recursor.cc

index 3a54b734a2910f5732c8dd0513f6ca32675c3cdd..a29a97186c69241f712e8cc8196c1d828d761a93 100644 (file)
@@ -3013,14 +3013,14 @@ try
 
   if(g_useOneSocketPerThread) {
     for (unsigned int threadId = 0; threadId < g_numWorkerThreads; threadId++) {
-      for(deferredAdd_t::const_iterator i = deferredAdds[threadId].begin(); i != deferredAdds[threadId].end(); ++i) {
+      for(deferredAdd_t::const_iterator i = deferredAdds[threadId].cbegin(); i != deferredAdds[threadId].cend(); ++i) {
         t_fdm->addReadFD(i->first, i->second);
       }
     }
   }
   else {
     if(!g_weDistributeQueries || !t_id) { // if we distribute queries, only t_id = 0 listens
-      for(deferredAdd_t::const_iterator i = deferredAdds[0].begin(); i != deferredAdds[0].end(); ++i) {
+      for(deferredAdd_t::const_iterator i = deferredAdds[0].cbegin(); i != deferredAdds[0].cend(); ++i) {
         t_fdm->addReadFD(i->first, i->second);
       }
     }