Reverse out use of Py_RETURN_TRUE in plpython, only supported in Python >=
authorBruce Momjian <bruce@momjian.us>
Thu, 25 Jan 2007 14:52:23 +0000 (14:52 +0000)
committerBruce Momjian <bruce@momjian.us>
Thu, 25 Jan 2007 14:52:23 +0000 (14:52 +0000)
2.3.

src/pl/plpython/plpython.c

index d5651c16f0cff90f27839205a5f7b6a0f11c328e..f8d02f425be0dfbe2dbbc5f0a6c8b951db5850fa 100644 (file)
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plpython.c - python as a procedural language for PostgreSQL
  *
- *     $PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.91 2007/01/25 04:08:51 momjian Exp $
+ *     $PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.92 2007/01/25 14:52:23 momjian Exp $
  *
  *********************************************************************
  */
@@ -1579,9 +1579,15 @@ PLy_typeinfo_dealloc(PLyTypeInfo * arg)
 static PyObject *
 PLyBool_FromString(const char *src)
 {
+       /*
+        *      We would like to use Py_RETURN_TRUE and Py_RETURN_FALSE here for
+        *      generating SQL from trigger functions, but those are only
+        *      supported in Python >= 2.3, and we support older
+        *      versions.  http://docs.python.org/api/boolObjects.html
+        */
        if (src[0] == 't')
-               Py_RETURN_TRUE;
-       Py_RETURN_FALSE;
+               return PyInt_FromLong(1);
+       return PyInt_FromLong(0);
 }
 
 static PyObject *