]> granicus.if.org Git - python/commitdiff
Merged revision 79605 via svnmerge from
authorFlorent Xicluna <florent.xicluna@gmail.com>
Sat, 3 Apr 2010 00:45:27 +0000 (00:45 +0000)
committerFlorent Xicluna <florent.xicluna@gmail.com>
Sat, 3 Apr 2010 00:45:27 +0000 (00:45 +0000)
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r79605 | antoine.pitrou | 2010-04-02 19:12:12 +0200 (ven, 02 avr 2010) | 3 lines

  Furniture is not very reliable these days (buildbot failures).
........

Lib/test/test_robotparser.py

index cc8b3900e44fdb4c1d8496206726e48ccff016d3..4c3b5363fd1f28a8c979cbc69ab99970f6d9faff 100644 (file)
@@ -1,6 +1,7 @@
 import io
 import unittest
 import urllib.robotparser
+from urllib.error import URLError
 from test import support
 
 class RobotTestCase(unittest.TestCase):
@@ -208,18 +209,19 @@ RobotTest(13, doc, good, bad, agent="googlebot")
 class NetworkTestCase(unittest.TestCase):
 
     def testPasswordProtectedSite(self):
-        if not support.is_resource_enabled('network'):
-            return
-        # whole site is password-protected.
+        support.requires('network')
+        # XXX it depends on an external resource which could be unavailable
         url = 'http://mueblesmoraleda.com'
         parser = urllib.robotparser.RobotFileParser()
         parser.set_url(url)
-        parser.read()
+        try:
+            parser.read()
+        except URLError:
+            self.skipTest('%s is unavailable' % url)
         self.assertEqual(parser.can_fetch("*", url+"/robots.txt"), False)
 
     def testPythonOrg(self):
-        if not support.is_resource_enabled('network'):
-            return
+        support.requires('network')
         parser = urllib.robotparser.RobotFileParser(
             "http://www.python.org/robots.txt")
         parser.read()