Avoid using floating point arithmetic and rely on safe_emalloc

for the multiplication.

The actual size requirement is spelled out as:

** The result is written into a preallocated output buffer "out".
** "out" must be able to hold at least 2 +(257*n)/254 bytes.
** In other words, the output will be expanded by as much as 3
** bytes for every 254 bytes of input plus 2 bytes of fixed overhead.
** (This is approximately 2 + 1.0118*n or about a 1.2% size increase.)

diff --git a/ext/sqlite/sess_sqlite.c b/ext/sqlite/sess_sqlite.c
index c9616bc07d7bad97f47db78a63a83a7620fdcad2..8789cd61095a973df12e88824ffb1ea711de2376 100644 (file)
--- a/ext/sqlite/sess_sqlite.c
+++ b/ext/sqlite/sess_sqlite.c
@@ -142,7 +142,7 @@ PS_WRITE_FUNC(sqlite)
        
        t = time(NULL);
 
-       binary = emalloc(1 + 5 + vallen * ((float) 256 / (float) 253));
+       binary = safe_emalloc(1 + vallen / 254, 257, 3);
        binlen = sqlite_encode_binary((const unsigned char*)val, vallen, binary);
        
        rv = sqlite_exec_printf(db, "REPLACE INTO session_data VALUES('%q', '%q', %d)", NULL, NULL, &error, key, binary, t);