]> granicus.if.org Git - apache/commitdiff
Re-allow '_' (underscore) in hostnames.
authorEric Covener <covener@apache.org>
Mon, 25 Jun 2018 13:18:24 +0000 (13:18 +0000)
committerEric Covener <covener@apache.org>
Mon, 25 Jun 2018 13:18:24 +0000 (13:18 +0000)
'_' was not permitted in hostnames since 2.4.25's "HTTP Strict"
changes.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1834318 13f79535-47bb-0310-9956-ffa450edef68

CHANGES
server/vhost.c

diff --git a/CHANGES b/CHANGES
index 611e69a9a41194684367884fa93ac19eda79607d..6e9f075c93d02fd41140fb3dafedf0110093a71e 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,5 +1,9 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.5.1
+
+  *) core: Re-allow '_' (underscore) in hostnames.
+     [Eric Covener]
+
   *) ru, zh-cn and zh-tw translations of errordocs have been added.
      Contributed by Alexander Gaganashvili and CodeingBoy
   
index dc9689d2c0e2542c0dcf7252208b2ddc341bdc35..45f521269ebbf0661f12ebd138b77a837e78f71d 100644 (file)
@@ -760,7 +760,7 @@ static apr_status_t strict_hostname_check(request_rec *r, char *host)
     int is_dotted_decimal = 1, leading_zeroes = 0, dots = 0;
 
     for (ch = host; *ch; ch++) {
-        if (apr_isalpha(*ch) || *ch == '-') {
+        if (apr_isalpha(*ch) || *ch == '-' || *ch == '_') {
             is_dotted_decimal = 0;
         }
         else if (ch[0] == '.') {