]> granicus.if.org Git - apache/commitdiff
dont va_start() in ssl_log() unless we are actually going to log something
authorDoug MacEachern <dougm@apache.org>
Thu, 22 Nov 2001 02:58:07 +0000 (02:58 +0000)
committerDoug MacEachern <dougm@apache.org>
Thu, 22 Nov 2001 02:58:07 +0000 (02:58 +0000)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92123 13f79535-47bb-0310-9956-ffa450edef68

modules/ssl/ssl_engine_log.c

index 378a29bf168f959e4198948c378539441c0e9c20..19cba44e37912aa6da2027ded688d3102523ad11 100644 (file)
@@ -196,7 +196,6 @@ void ssl_log(server_rec *s, int level, const char *msg, ...)
     char *cpA;
 
     /*  initialization  */
-    va_start(ap, msg);
     safe_errno = errno;
     sc = mySrvConfig(s);
 
@@ -251,7 +250,9 @@ void ssl_log(server_rec *s, int level, const char *msg, ...)
     }
 
     /*  create custom message  */
+    va_start(ap, msg);
     apr_vsnprintf(vstr, sizeof(vstr), msg, ap);
+    va_end(ap);
 
     /*  write out SSLog message  */
     if ((add & SSL_ADD_ERRNO) && (add & SSL_ADD_SSLERR))
@@ -309,7 +310,6 @@ void ssl_log(server_rec *s, int level, const char *msg, ...)
     if (sc->fileLogFile != NULL)
         apr_file_flush(sc->fileLogFile);
     errno = safe_errno;
-    va_end(ap);
     return;
 }