]> granicus.if.org Git - strace/commitdiff
sysmips.c: cleanup
authorDmitry V. Levin <ldv@altlinux.org>
Thu, 16 Jul 2015 21:46:05 +0000 (21:46 +0000)
committerDmitry V. Levin <ldv@altlinux.org>
Thu, 16 Jul 2015 22:58:12 +0000 (22:58 +0000)
* sysmips.c [MIPS] (sys_sysmips): Use switch statement.  Use printaddr.
Fix misprinted ", " delimiter.

sysmips.c

index 36ee9b9db25bb6f17946fade343282baf1cfe237..a47facf98c431e36de884d020bba77843f99d542 100644 (file)
--- a/sysmips.c
+++ b/sysmips.c
 SYS_FUNC(sysmips)
 {
        printxval(sysmips_operations, tcp->u_arg[0], "???");
-       if (!verbose(tcp)) {
-               tprintf("%ld, %ld, %ld", tcp->u_arg[1], tcp->u_arg[2], tcp->u_arg[3]);
-       } else if (tcp->u_arg[0] == SETNAME) {
+       tprints(", ");
+
+       switch (tcp->u_arg[0]) {
+       case SETNAME: {
                char nodename[__NEW_UTS_LEN + 1];
-               tprints(", ");
+
+               if (!verbose(tcp))
+                       break;
                if (umovestr(tcp, tcp->u_arg[1], (__NEW_UTS_LEN + 1),
                             nodename) < 0) {
-                       tprintf("%#lx", tcp->u_arg[1]);
+                       printaddr(tcp->u_arg[1]);
                } else {
                        print_quoted_string(nodename, __NEW_UTS_LEN + 1,
                                            QUOTE_0_TERMINATED);
                }
-       } else if (tcp->u_arg[0] == MIPS_ATOMIC_SET) {
-               tprintf(", %#lx, 0x%lx", tcp->u_arg[1], tcp->u_arg[2]);
-       } else if (tcp->u_arg[0] == MIPS_FIXADE) {
-               tprintf(", 0x%lx", tcp->u_arg[1]);
-       } else {
-               tprintf("%ld, %ld, %ld", tcp->u_arg[1], tcp->u_arg[2], tcp->u_arg[3]);
+               return RVAL_DECODED;
+       }
+       case MIPS_ATOMIC_SET:
+               tprintf("%#lx, 0x%lx", tcp->u_arg[1], tcp->u_arg[2]);
+               return RVAL_DECODED;
+       case MIPS_FIXADE:
+               tprintf("0x%lx", tcp->u_arg[1]);
+               return RVAL_DECODED;
        }
 
+       tprintf("%ld, %ld, %ld", tcp->u_arg[1], tcp->u_arg[2], tcp->u_arg[3]);
        return RVAL_DECODED;
 }