]> granicus.if.org Git - clang/commitdiff
Move -Wswitch from -Wmost to -Wall, consitent with GCC.
authorDavid Blaikie <dblaikie@gmail.com>
Fri, 10 Feb 2012 05:15:16 +0000 (05:15 +0000)
committerDavid Blaikie <dblaikie@gmail.com>
Fri, 10 Feb 2012 05:15:16 +0000 (05:15 +0000)
This is a relatively noisy warning for a codebase not explicitly designed for
it (effectively enforcing a stylistic constraint about the use of defaults
in switches over enums) & there's nothing Clang does to clean up the noise
when compared to GCC's implementation so the same decision seems suitable.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@150230 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/Basic/DiagnosticGroups.td

index 1a733d28e0f874f9a008db9ea2abc967fb924927..4fa19826b9beb3ffbfbb166c979fb2faf645b1e9 100644 (file)
@@ -317,7 +317,6 @@ def Most : DiagGroup<"most", [
     Reorder,
     ReturnType,
     SelfAssignment,
-    Switch,
     SizeofArrayArgument,
     Trigraphs,
     Uninitialized,
@@ -331,8 +330,8 @@ def Most : DiagGroup<"most", [
 // Thread Safety warnings 
 def ThreadSafety : DiagGroup<"thread-safety">;
 
-// -Wall is -Wmost -Wparentheses -Wdangling-else
-def : DiagGroup<"all", [DanglingElse, Most, Parentheses]>;
+// -Wall is -Wmost -Wparentheses -Wdangling-else -Wswitch
+def : DiagGroup<"all", [DanglingElse, Most, Parentheses, Switch]>;
 
 // Aliases.
 def : DiagGroup<"", [Extra]>;                   // -W = -Wextra