]> granicus.if.org Git - python/commitdiff
Merged revisions 86940 via svnmerge from
authorÉric Araujo <merwok@netwok.org>
Thu, 2 Dec 2010 22:29:59 +0000 (22:29 +0000)
committerÉric Araujo <merwok@netwok.org>
Thu, 2 Dec 2010 22:29:59 +0000 (22:29 +0000)
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86940 | eric.araujo | 2010-12-02 23:16:19 +0100 (jeu., 02 déc. 2010) | 2 lines

  Fix wrong test code in test_csv (#10602)
........

Lib/test/test_csv.py

index 75d1a91cefb85f06b35ab634c90f53cee66f98f9..d553a78bbcb5ca3bbd0d6009a27b99ec15f788dd 100644 (file)
@@ -314,22 +314,17 @@ class TestDialectRegistry(unittest.TestCase):
         expected_dialects = csv.list_dialects() + [name]
         expected_dialects.sort()
         csv.register_dialect(name, myexceltsv)
-        try:
-            self.assertTrue(csv.get_dialect(name).delimiter, '\t')
-            got_dialects = csv.list_dialects()
-            got_dialects.sort()
-            self.assertEqual(expected_dialects, got_dialects)
-        finally:
-            csv.unregister_dialect(name)
+        self.addCleanup(csv.unregister_dialect, name)
+        self.assertEqual(csv.get_dialect(name).delimiter, '\t')
+        got_dialects = sorted(csv.list_dialects())
+        self.assertEqual(expected_dialects, got_dialects)
 
     def test_register_kwargs(self):
         name = 'fedcba'
         csv.register_dialect(name, delimiter=';')
-        try:
-            self.assertTrue(csv.get_dialect(name).delimiter, '\t')
-            self.assertTrue(list(csv.reader('X;Y;Z', name)), ['X', 'Y', 'Z'])
-        finally:
-            csv.unregister_dialect(name)
+        self.addCleanup(csv.unregister_dialect, name)
+        self.assertEqual(csv.get_dialect(name).delimiter, ';')
+        self.assertEqual([['X', 'Y', 'Z']], list(csv.reader(['X;Y;Z'], name)))
 
     def test_incomplete_dialect(self):
         class myexceltsv(csv.Dialect):