]> granicus.if.org Git - llvm/commitdiff
[codeview] Improve some comments
authorReid Kleckner <rnk@google.com>
Thu, 5 May 2016 20:58:46 +0000 (20:58 +0000)
committerReid Kleckner <rnk@google.com>
Thu, 5 May 2016 20:58:46 +0000 (20:58 +0000)
This FIXME was already fixed, and these LF_* enum names were
inconsistent.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@268683 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/DebugInfo/CodeView/TypeRecord.h
lib/DebugInfo/CodeView/TypeDumper.cpp

index d6b323c8d8322ab017aff5fc42fbcb6cbcf2e995..cd70bcf3b73ae60935d5370dd15c6d2d9326e1fa 100644 (file)
@@ -299,7 +299,7 @@ struct FuncId {
   // Name: The null-terminated name follows.
 };
 
-// LF_CLASS, LF_STRUCT, LF_INTERFACE
+// LF_CLASS, LF_STRUCTURE, LF_INTERFACE
 struct ClassType {
   ulittle16_t MemberCount; // Number of members in FieldList.
   ulittle16_t Properties;  // ClassOptions bitset
@@ -501,6 +501,7 @@ struct OneMethod {
   bool isIntroducedVirtual() const { return Attrs.isIntroducedVirtual(); }
 };
 
+// LF_METHODLIST
 struct MethodListEntry {
   MemberAttributes Attrs;
   ulittle16_t Padding;
@@ -559,7 +560,7 @@ struct BaseClass {
   // BaseOffset: LF_NUMERIC encoded byte offset of base from derived.
 };
 
-// LF_VBCLASS | LV_IVBCLASS
+// LF_VBCLASS, LF_IVBCLASS
 struct VirtualBaseClass {
   MemberAttributes Attrs; // Access control attributes, etc.
   TypeIndex BaseType;     // Base class type
index 8139484a6a03ce704496b21b37bda34813a4ddc8..bb3859a05902878391f49acd9722515b9b438e88 100644 (file)
@@ -200,7 +200,6 @@ public:
       : CVTD(CVTD), W(W), PrintRecordBytes(PrintRecordBytes) {}
 
   /// CVTypeVisitor overrides.
-  /// FIXME: Bury these in the .cc file to hide implementation details.
 #define TYPE_RECORD(ClassName, LeafEnum)                                       \
   void visit##ClassName(TypeLeafKind LeafType, const ClassName *Record,        \
                         ArrayRef<uint8_t> LeafData);