]> granicus.if.org Git - apache/commitdiff
Clarify potentially unsuccessful success results.
authorWilliam A. Rowe Jr <wrowe@apache.org>
Thu, 17 Jan 2019 17:19:04 +0000 (17:19 +0000)
committerWilliam A. Rowe Jr <wrowe@apache.org>
Thu, 17 Jan 2019 17:19:04 +0000 (17:19 +0000)
Curious why modules/aaa/mod_authz_dbm.c:get_dbm_grp() doesn't need the same
net changes?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851552 13f79535-47bb-0310-9956-ffa450edef68

modules/aaa/mod_authn_dbm.c

index 46fe6ffc8025886eb5277fd0489a7aefe6ffef3c..e54058563b1fe327a3639e5439bfd8cc6770f0a8 100644 (file)
@@ -101,6 +101,10 @@ static apr_status_t fetch_dbm_value(const char *dbmtype, const char *dbmfile,
 
     apr_dbm_close(f);
 
+    /* NOT FOUND is not an error case; this is indicated by a NULL result.
+     * Treat all NULL lookup/error results as success for the simple case 
+     * of auth credential lookup, these are DECLINED in both cases.
+     */
     return APR_SUCCESS;
 }