Return a value from Install.pm's lcopy function

Commit 3a7cc727c was a little over eager about adding an explicit return
to this function, whose value is checked in most call sites. This change
reverses that and returns the expected value explicitly. It also adds a
check to the one call site lacking one.

diff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm
index 6f1c30546aeee1184e71f44477cc024dac7dbb6c..429608fde61b00037965a2574747a2ee7c2bbda9 100644 (file)
--- a/src/tools/msvc/Install.pm
+++ b/src/tools/msvc/Install.pm
@@ -37,10 +37,10 @@ sub lcopy
                unlink $target || confess "Could not delete $target\n";
        }
 
-       copy($src, $target)
+       (my $retval = copy($src, $target))
          || confess "Could not copy $src to $target\n";
 
-       return;
+       return $retval;
 }
 
 sub Install
@@ -200,7 +200,7 @@ sub CopyFiles
                print ".";
                $f = $basedir . $f;
                die "No file $f\n" if (!-f $f);
-               lcopy($f, $target . basename($f));
+               lcopy($f, $target . basename($f)) || croak "Could not copy $f: $!\n";
        }
        print "\n";
        return;