]> granicus.if.org Git - clang/commitdiff
Allow dynamic_cast to void* even with -fno-rtti.
authorEli Friedman <eli.friedman@gmail.com>
Tue, 24 Sep 2013 23:21:41 +0000 (23:21 +0000)
committerEli Friedman <eli.friedman@gmail.com>
Tue, 24 Sep 2013 23:21:41 +0000 (23:21 +0000)
PR17346.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191340 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaCast.cpp
test/SemaCXX/no-rtti.cpp

index 46b5b45306485dbb50ea8cdd3a2a6b8b8cb510b6..ba00b712aad566ea12ad4f01a65943d0107065fc 100644 (file)
@@ -669,8 +669,10 @@ void CastOperation::CheckDynamicCast() {
   Self.MarkVTableUsed(OpRange.getBegin(), 
                       cast<CXXRecordDecl>(SrcRecord->getDecl()));
 
-  // dynamic_cast is not available with fno-rtti
-  if (!Self.getLangOpts().RTTI) {
+  // dynamic_cast is not available with -fno-rtti.
+  // As an exception, dynamic_cast to void* is available because it doesn't
+  // use RTTI.
+  if (!Self.getLangOpts().RTTI && !DestPointee->isVoidType()) {
     Self.Diag(OpRange.getBegin(), diag::err_no_dynamic_cast_with_fno_rtti);
     SrcExpr = ExprError();
     return;
index 3d6e109551d4676babd5dddd0e6c5c676f2933b7..a171b3cde2c36cf41b765d4b8e70dcfb43c6b7c9 100644 (file)
@@ -22,3 +22,8 @@ struct B : public A {
 bool isa_B(A *a) {
   return dynamic_cast<B *>(a) != 0; // expected-error {{cannot use dynamic_cast with -fno-rtti}}
 }
+
+void* getMostDerived(A* a) {
+  // This cast does not use RTTI.
+  return dynamic_cast<void *>(a);
+}