]> granicus.if.org Git - taglib/commitdiff
Don't use const ref to an integer in ChapterFrame
authorLukáš Lalinský <lukas@oxygene.sk>
Sun, 23 Aug 2015 10:10:12 +0000 (12:10 +0200)
committerLukáš Lalinský <lukas@oxygene.sk>
Sun, 23 Aug 2015 10:20:25 +0000 (12:20 +0200)
taglib/mpeg/id3v2/frames/chapterframe.cpp
taglib/mpeg/id3v2/frames/chapterframe.h

index ad471ecd6b0a1321c579d2df0cbe8ac35cdc77bd..e11e2928b7e588083ea20d2c2d1974a05081d8c9 100644 (file)
@@ -65,8 +65,8 @@ ChapterFrame::ChapterFrame(const ID3v2::Header *tagHeader, const ByteVector &dat
 }
 
 ChapterFrame::ChapterFrame(const ByteVector &elementID,
-                           const TagLib::uint &startTime, const TagLib::uint &endTime,
-                           const TagLib::uint &startOffset, const TagLib::uint &endOffset,
+                           TagLib::uint startTime, TagLib::uint endTime,
+                           TagLib::uint startOffset, TagLib::uint endOffset,
                            const FrameList &embeddedFrames) :
     ID3v2::Frame("CHAP")
 {
index 692895ee8a2da0d2970d924624bbf4cf0c3a6333..36853062161a90c29dbb89753975dc6610f99419 100644 (file)
@@ -61,10 +61,9 @@ namespace TagLib {
        *
        * All times are in milliseconds.
        */
-      // BIC: There's no reason to use const-references with uints
       ChapterFrame(const ByteVector &elementID,
-                   const uint &startTime, const uint &endTime,
-                   const uint &startOffset, const uint &endOffset,
+                   uint startTime, uint endTime,
+                   uint startOffset, uint endOffset,
                    const FrameList &embeddedFrames = FrameList());
 
       /*!