]> granicus.if.org Git - cgit/commitdiff
tests/: Do not use `sed -i`
authorLukas Fleischer <cgit@cryptocrack.de>
Tue, 9 Apr 2013 18:02:32 +0000 (20:02 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Wed, 10 Apr 2013 12:49:31 +0000 (14:49 +0200)
"-i" isn't part of the POSIX standard and doesn't work on several
platforms such as OpenBSD. Use a temporary file instead.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
tests/t0010-validate-html.sh
tests/t0020-validate-cache.sh

index 5bd0a252f18ad69cc1ff9947f56c5be3f419f8a8..ca08d69d142b216d14ab1c7773c9e18de2052740 100755 (executable)
@@ -8,8 +8,8 @@ test_url()
 {
        tidy_opt="-eq"
        test -z "$NO_TIDY_WARNINGS" || tidy_opt+=" --show-warnings no"
-       cgit_url "$1" >tidy-$test_count || return
-       sed -ie "1,4d" tidy-$test_count || return
+       cgit_url "$1" >tidy-$test_count.tmp || return
+       sed -e "1,4d" tidy-$test_count.tmp >tidy-$test_count || return
        "$tidy" $tidy_opt tidy-$test_count
        rc=$?
 
index 1910b471c8c88cbc19599b10d00b1210590fd06a..7e7379a80a898651484b4f395c5e4c3cc21c40e9 100755 (executable)
@@ -6,7 +6,8 @@ test_description='Validate cache'
 test_expect_success 'verify cache-size=0' '
 
        rm -f cache/* &&
-       sed -i -e "s/cache-size=1021$/cache-size=0/" cgitrc &&
+       sed -e "s/cache-size=1021$/cache-size=0/" cgitrc >cgitrc.tmp &&
+       mv -f cgitrc.tmp cgitrc &&
        cgit_url "" &&
        cgit_url "foo" &&
        cgit_url "foo/refs" &&
@@ -27,7 +28,8 @@ test_expect_success 'verify cache-size=0' '
 test_expect_success 'verify cache-size=1' '
 
        rm -f cache/* &&
-       sed -i -e "s/cache-size=0$/cache-size=1/" cgitrc &&
+       sed -e "s/cache-size=0$/cache-size=1/" cgitrc >cgitrc.tmp &&
+       mv -f cgitrc.tmp cgitrc &&
        cgit_url "" &&
        cgit_url "foo" &&
        cgit_url "foo/refs" &&
@@ -48,7 +50,8 @@ test_expect_success 'verify cache-size=1' '
 test_expect_success 'verify cache-size=1021' '
 
        rm -f cache/* &&
-       sed -i -e "s/cache-size=1$/cache-size=1021/" cgitrc &&
+       sed -e "s/cache-size=1$/cache-size=1021/" cgitrc >cgitrc.tmp &&
+       mv -f cgitrc.tmp cgitrc &&
        cgit_url "" &&
        cgit_url "foo" &&
        cgit_url "foo/refs" &&