]> granicus.if.org Git - llvm/commitdiff
[asan] Return true from instrumentModule
authorVitaly Buka <vitalybuka@google.com>
Sat, 12 Oct 2019 01:50:36 +0000 (01:50 +0000)
committerVitaly Buka <vitalybuka@google.com>
Sat, 12 Oct 2019 01:50:36 +0000 (01:50 +0000)
createSanitizerCtorAndInitFunctions always change the module.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@374623 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Instrumentation/AddressSanitizer.cpp

index 91b6a91ab81911feb09f05b737f426545ab3e860..ff0b7081946d15cfcd36c64a5a9fd2e18156acaa 100644 (file)
@@ -2439,11 +2439,10 @@ bool ModuleAddressSanitizer::instrumentModule(Module &M) {
       /*InitArgs=*/{}, VersionCheckName);
 
   bool CtorComdat = true;
-  bool Changed = false;
   // TODO(glider): temporarily disabled globals instrumentation for KASan.
   if (ClGlobals) {
     IRBuilder<> IRB(AsanCtorFunction->getEntryBlock().getTerminator());
-    Changed |= InstrumentGlobals(IRB, M, &CtorComdat);
+    InstrumentGlobals(IRB, M, &CtorComdat);
   }
 
   const uint64_t Priority = GetCtorAndDtorPriority(TargetTriple);
@@ -2464,7 +2463,7 @@ bool ModuleAddressSanitizer::instrumentModule(Module &M) {
       appendToGlobalDtors(M, AsanDtorFunction, Priority);
   }
 
-  return Changed;
+  return true;
 }
 
 void AddressSanitizer::initializeCallbacks(Module &M) {